-
-
Notifications
You must be signed in to change notification settings - Fork 228
[fix] Update zerotier network name from ow_zt to global #986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Update zerotier network name from ow_zt to global #986
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pandafy I think this one would be good to merge, wouldn't it?
@filippociandy10 the issue to reference is #982, you are referencing another PR from another contributor, please update the description, title and commit message accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA checks are failing, please run openwisp-qa-format as indicated in the contributing guidelines.
With that it should be ready to merge.
Thanks 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The migration script does not work as expected.
Fix issue so that it saves updated templates Co-authored-by: Gagan Deep <[email protected]>
… openwisp_controller/config/migrations/0056_ow_zt_to_global.py so that it correctly saves updated templates.\n\nFixes openwisp#982
Fix issue in openwisp_controller/config/migrations/0056_ow_zt_to_global.py so that it correctly saves updated templates. Fixes openwisp#982
Fix issue in openwisp_controller/config/migrations/0056_ow_zt_to_global.py so that it correctly saves updated templates. Fixes openwisp#982
|
@filippociandy10 I have made small changes in 5b5db6f. With that, it should be good to merge this. We can merge this after merging #990 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @filippociandy10 @pandafy 🙏
Checklist
Reference to Existing Issue
Fixes #982 .
Description of Changes
Changed ZeroTier network name from ow_zt to global by modifying migration file and also by updating the Vpn.auto_client method.