Skip to content

Conversation

@filippociandy10
Copy link
Contributor

@filippociandy10 filippociandy10 commented Mar 4, 2025

Checklist

  • I have read the OpenWISP Contributing Guidelines.
  • I have manually tested the changes proposed in this pull request.
  • I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • I have updated the documentation.

Reference to Existing Issue

Fixes #982 .

Description of Changes

Changed ZeroTier network name from ow_zt to global by modifying migration file and also by updating the Vpn.auto_client method.

@filippociandy10 filippociandy10 changed the title Filippociandy/ow_zt-to-global [fix]filippociandy/ow_zt-to-global Mar 4, 2025
@filippociandy10 filippociandy10 changed the title [fix]filippociandy/ow_zt-to-global [fix] change zerotier network name from ow_zt to global Mar 4, 2025
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pandafy I think this one would be good to merge, wouldn't it?

@filippociandy10 the issue to reference is #982, you are referencing another PR from another contributor, please update the description, title and commit message accordingly.

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA checks are failing, please run openwisp-qa-format as indicated in the contributing guidelines.

With that it should be ready to merge.

Thanks 🙏

Copy link
Member

@pandafy pandafy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The migration script does not work as expected.

@pandafy pandafy moved this from To do (general) to In progress in OpenWISP Contributor's Board Mar 10, 2025
Fix issue so that it saves updated templates

Co-authored-by: Gagan Deep <[email protected]>
atlas and others added 4 commits March 13, 2025 17:20
… openwisp_controller/config/migrations/0056_ow_zt_to_global.py so that it correctly saves updated templates.\n\nFixes openwisp#982
Fix issue in openwisp_controller/config/migrations/0056_ow_zt_to_global.py so that it correctly saves updated templates.

Fixes openwisp#982
Fix issue in openwisp_controller/config/migrations/0056_ow_zt_to_global.py so that it correctly saves updated templates.

Fixes openwisp#982
@pandafy
Copy link
Member

pandafy commented Mar 19, 2025

@filippociandy10 I have made small changes in 5b5db6f. With that, it should be good to merge this.

We can merge this after merging #990

pandafy
pandafy previously approved these changes Mar 19, 2025
@nemesifier nemesifier changed the title [fix] change zerotier network name from ow_zt to global [fix] Update zerotier network name from ow_zt to global Mar 20, 2025
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nemesifier nemesifier merged commit 4881326 into openwisp:master Mar 20, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in OpenWISP Contributor's Board Mar 20, 2025
@coveralls
Copy link

Coverage Status

coverage: 98.884%. remained the same
when pulling 7133d29 on filippociandy10:filippociandy/ow_zt-to-global
into 8288c23 on openwisp:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

[bug] Change ZeroTier network name from ow_zt to global

4 participants