monitoring/api/views.py added the rest api parameters in the swagge…#718
Open
Piyushrathoree wants to merge 2 commits intoopenwisp:masterfrom
Conversation
Author
|
PTAL @nemesifier |
Piyushrathoree
force-pushed
the
issue/715-bug-Dashboard-API-filters-not-shown-in-API-docs/browsable-API
branch
from
dd02077 to
ca71922
Compare
Piyushrathoree
changed the title
…own-in-API-docs/browsable-API
Author
|
@pandafy could you please review this , or if there is any problem please let me know so that I can fix it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
monitoring/api/views.py added the rest api parameters in the swagger docs #715.
there are some parameter on api/v1/monitoring/dashboard endpoint which are mentioned in the api docs but those parameter are not available in the swagger docs and redoc, and my changes solve this issue I have implemented the @swagger_auto_schema decorator which lets this parameter appear in the swagger ui and redoc.
fixes #715
Checklist
Description of Changes
first the swagger ui was not showing the parameter fields on api/v1/monitoring/dashboard endpoint in swagger and redoc , and I've made some changes which lets the parameter fields appear in swagger and redoc docs.
Screenshot