Skip to content

Conversation

@pandafy
Copy link
Member

@pandafy pandafy commented Dec 18, 2024

Checklist

  • I have read the OpenWISP Contributing Guidelines.
  • I have manually tested the changes proposed in this pull request.
  • I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • I have updated the documentation.

@coveralls
Copy link

coveralls commented Dec 18, 2024

Coverage Status

coverage: 96.18%. remained the same
when pulling d9465e4 on duplicate-1.2.0
into 8ad7519 on master.

@pandafy
Copy link
Member Author

pandafy commented Dec 18, 2024

I have tested the GitHub action on my fork:

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to create a reusable github action so we don't need to duplicate this in each repo? That would allow us to change this for all repos from a single place.

else
git checkout -b $VERSION
fi
git push origin $VERSION
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens here if we ever need to push force on master?

Copy link
Member Author

@pandafy pandafy Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This action would fail in thi scenario. Shall I update the command to perform force-push?

@pandafy
Copy link
Member Author

pandafy commented Dec 18, 2024

Is there a way to create a reusable github action so we don't need to duplicate this in each repo? That would allow us to change this for all repos from a single place.

We will need to find a way to automatically get the module name. Maybe, we can set this as an input parameter in GitHub workflow.

Created re-usable workflow for replication commits from the
master branch to version branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

4 participants