-
-
Notifications
You must be signed in to change notification settings - Fork 88
[ci] Added GitHub workflow to replicate commits to version branch #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5fd5bcb to
9e01094
Compare
|
I have tested the GitHub action on my fork: |
nemesifier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to create a reusable github action so we don't need to duplicate this in each repo? That would allow us to change this for all repos from a single place.
.github/workflows/version-branch.yml
Outdated
| else | ||
| git checkout -b $VERSION | ||
| fi | ||
| git push origin $VERSION |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens here if we ever need to push force on master?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This action would fail in thi scenario. Shall I update the command to perform force-push?
We will need to find a way to automatically get the module name. Maybe, we can set this as an input parameter in GitHub workflow. |
5eb3606 to
476e3b4
Compare
476e3b4 to
3b51f3d
Compare
3b51f3d to
6a9f4f7
Compare
Created re-usable workflow for replication commits from the master branch to version branch.
6a9f4f7 to
d9465e4
Compare
Checklist