Skip to content

Comments

[tests] Added ability to read browser console logs + test utilities cleanup#447

Merged
nemesifier merged 13 commits intomasterfrom
browser-logs
Mar 14, 2025
Merged

[tests] Added ability to read browser console logs + test utilities cleanup#447
nemesifier merged 13 commits intomasterfrom
browser-logs

Conversation

@pandafy
Copy link
Member

@pandafy pandafy commented Mar 13, 2025

Checklist

  • I have read the OpenWISP Contributing Guidelines.
  • I have manually tested the changes proposed in this pull request.
  • I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • I have updated the documentation.

@pandafy pandafy force-pushed the browser-logs branch 3 times, most recently from ad73a3b to fc6d35e Compare March 13, 2025 17:10
@coveralls
Copy link

coveralls commented Mar 13, 2025

Coverage Status

coverage: 96.224% (+0.3%) from 95.947%
when pulling e77e8f7 on browser-logs
into 44890ad on master.

Firefox does not support the WebDriver.get_log API. To work around this,
we inject JavaScript into the page to override window.console within the
browser's JS runtime. This allows us to capture and retrieve console errors
directly from the page.
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pandafy please update the docs in regards to chromium.

Let's add a bit of tests to avoid the coverage going down.

@github-project-automation github-project-automation bot moved this from To do (general) to In progress in OpenWISP Contributor's Board Mar 14, 2025
@nemesifier nemesifier changed the title [tests] Added ability to read browser console logs [tests] Added ability to read browser console logs + test utilities cleanup Mar 14, 2025
@nemesifier nemesifier merged commit e77e8f7 into master Mar 14, 2025
15 checks passed
@nemesifier nemesifier deleted the browser-logs branch March 14, 2025 19:43
@github-project-automation github-project-automation bot moved this from In progress to Done in OpenWISP Contributor's Board Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants