[tests] Added ability to read browser console logs + test utilities cleanup#447
Merged
nemesifier merged 13 commits intomasterfrom Mar 14, 2025
Merged
[tests] Added ability to read browser console logs + test utilities cleanup#447nemesifier merged 13 commits intomasterfrom
nemesifier merged 13 commits intomasterfrom
Conversation
ad73a3b to
fc6d35e
Compare
Firefox does not support the WebDriver.get_log API. To work around this, we inject JavaScript into the page to override window.console within the browser's JS runtime. This allows us to capture and retrieve console errors directly from the page.
nemesifier
requested changes
Mar 14, 2025
Member
nemesifier
left a comment
There was a problem hiding this comment.
@pandafy please update the docs in regards to chromium.
Let's add a bit of tests to avoid the coverage going down.
ede736a to
00d49f1
Compare
e19aaab to
d05262c
Compare
994d16a to
72f552f
Compare
72f552f to
e77e8f7
Compare
nemesifier
approved these changes
Mar 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist