Test: Create test for get_instance for White Whole#49
Conversation
|
Hi @pgleeson , at your earliest convenience, would you let me know if I'm on the right track with this PR? If I am, I'll clean it up and make additional tests. |
|
Will look it over tomorrow @nanoman657, thanks. |
|
Thanks again for this. The reason that the WhiteDataReader didn't have a get_instnce method was because it was really a helperclass for White_whole, White_A etc. which do use specific spreadsheets and so are full connectome dataset. Test classes can maybe be added for these "real" connectome datasets |
|
By the way, do base your PRs on the latets main in the https://github.com/openworm/ConnectomeToolbox/ repo. |
25baf82 to
74ea77d
Compare
74ea77d to
9f7dfcc
Compare
get_instance for White Data Readerget_instance for White Whole
|
Thanks @pgleeson for your feedback. To address your comment, I have adjusted the commits to address the White_whole.py file instead. I have also rebased on the latest Connectome Toolbox repository. Please let me know if the edits made are satisfactory. |
|
Thanks, testing this out, unfortunately the GHA tests take an hour to run, so difficult not to get distracted by other things... |
|
@pgleeson No worries! I see that some of the builds have failed, so I'll work to correct those. |
|
Thanks @nanoman657, have tested this and merged it in. Note this change I made: ConnectomeToolbox/cect/tests/test_white_whole.py Lines 43 to 46 in 8e3875b i.e. if the test is run, and the cache file to generate already exists, don't delete it. In this case the cache file has been added to the repo. |
|
Also, this (0967715) puts a limit on the version of hiveplotlib to use, which prevents the test from failing. |
Test the
get_instancefunction for the White_whole dataset.White_whole has a
get_instancefunction like other complete connectome datasets. However, it has been untested, which creates risk for further development of the Connectome Toolbox. This PR tests the function, while also including abstracted caching logic which could also be extended to other data readers.Notes: