Conversation
|
Good stuff! Two more things:
|
systemcrash
force-pushed
the
tzdb
branch
3 times, most recently
from
79a0f29 to
5299542
Compare
Potentially yes - but generally once a user sets a timezone, they rarely change it. Wondering if it's worth it, even though it's 'correct' :) All done. |
It was partially a reminder to self...I'm going to have to do something similar when I get around to updating the global DUID PR |
|
The second version looks so much cleaner (IMHO) |
|
OK - sweet. Thanks for the pointers. Low fat. Way better than v0. If there are no further comments, LGTM. |
This implements RFC4833 - supplying timezone information to clients that
request them. Both forms are possible, when timezone is configured in
the uci system settings (the luci GUI saves both forms to the config).
e.g.
```
config system
option zonename 'America/Puerto Rico'
option timezone 'AST4'
```
There is also an odhcpd flag to disable their use, set in uci dhcp.
```
config odhcpd 'odhcpd'
option enable_tzdb '0'
```
Once enabled, the options, when requested, are sent:
NEW_POSIX_TIMEZONE 41 // 'AST4'
NEW_TZDB_TIMEZONE 42 // 'America/Puerto_Rico'
Wireshark disassemble of options sent to client:
```
...
Time Zone Database
Option: Time Zone Database (42)
Length: 19
TZ-database: America/Puerto_Rico
Time Zone
Option: Time Zone (41)
Length: 4
Time-zone: AST4
```
Signed-off-by: Paul Donald <newtwen+github@gmail.com>
|
Purty. Still don't like |
|
Ready when you are @Noltari. I've tested the latest iteration on my production system and it performs as expected. |
This implements RFC4833 - supplying timezone information to clients that
request them. Both forms are possible, when timezone is configured in
the uci system settings (the luci GUI saves both forms to the config).
e.g.
```
config system
option zonename 'America/Puerto Rico'
option timezone 'AST4'
```
There is also an odhcpd flag to disable their use, set in uci dhcp.
```
config odhcpd 'odhcpd'
option enable_tzdb '0'
```
Once enabled, the options, when requested, are sent:
NEW_POSIX_TIMEZONE 41 // 'AST4'
NEW_TZDB_TIMEZONE 42 // 'America/Puerto_Rico'
Wireshark disassemble of options sent to client:
```
...
Time Zone Database
Option: Time Zone Database (42)
Length: 19
TZ-database: America/Puerto_Rico
Time Zone
Option: Time Zone (41)
Length: 4
Time-zone: AST4
```
Signed-off-by: Paul Donald <newtwen+github@gmail.com>
Link: #284
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
|
Merged, thanks @systemcrash! |
|
@Noltari out of curiosity...why are some PRs closed after merge (like this one) and some marked as merged? |
Normally Github will automatically close PRs if the same commits are added to the branch referenced by the PR. |
3 participants
ping @Alphix and @Noltari
Can you see anything that should be improved here? This option differs from the others in that it's not an interface option, but instead just an internal
system_configthing. I made it 'opt in', so the user must specifically enable its usage, so if there are any gremlins through its usage, they can be disabled.====
This implements RFC4833 - supplying timezone information to clients that request them. Both forms are possible, when timezone is configured in the uci system settings (it saves both forms to the config).
e.g.
There is also an odhcpd flag to toggle their use, set in uci dhcp.
Once enabled, the options, when requested, are sent:
NEW_POSIX_TIMEZONE 41 // 'AST4'
NEW_TZDB_TIMEZONE 42 // 'America/Puerto_Rico'
Wireshark disassemble of options sent to client: