dhcpv6-ia: IA case refactor#360
Merged
openwrt-bot merged 1 commit intoopenwrt:masterfrom Dec 22, 2025
Merged
Conversation
systemcrash
force-pushed
the
ia_switches
branch
from
8898405 to
7751bcc
Compare
Contributor
Author
|
So... I've been running this for a while now, although I'd feel better if others could pick and run this in production to verify also. I don't see any behaviour changes. The rebind case that was moved to the end is semantically identical, and those look the same in my captures. |
Noltari
requested changes
Dec 22, 2025
systemcrash
force-pushed
the
ia_switches
branch
from
7751bcc to
a95b107
Compare
Member
|
@systemcrash should we squash both commits since the title/description are exactly the same? |
Contributor
Author
|
Sure. Wanted to make review easier. |
systemcrash
force-pushed
the
ia_switches
branch
from
a95b107 to
1aad8be
Compare
Noltari
pushed a commit
to systemcrash/odhcpd
that referenced
this pull request
Dec 22, 2025
Rewrite core logic using switch cases for clarity and improved performance. This also simplifies the DHCPV6_MSG_REBIND cases: DHCPV6_MSG_REBIND and !a is parsed in the switch DHCPV6_MSG_REBIND and a is now parsed after the switch (5 lines) Signed-off-by: Paul Donald <newtwen+github@gmail.com> openwrt#360 Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Rewrite core logic using switch cases for clarity and improved performance. This also simplifies the DHCPV6_MSG_REBIND cases: DHCPV6_MSG_REBIND and !a is parsed in the switch DHCPV6_MSG_REBIND and a is now parsed after the switch (5 lines) Signed-off-by: Paul Donald <newtwen+github@gmail.com> openwrt#360 Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Member
|
Merged, thanks @systemcrash! |
Noltari
pushed a commit
to Noltari/odhcpd
that referenced
this pull request
Jan 25, 2026
Rewrite core logic using switch cases for clarity and improved performance. This also simplifies the DHCPV6_MSG_REBIND cases: DHCPV6_MSG_REBIND and !a is parsed in the switch DHCPV6_MSG_REBIND and a is now parsed after the switch (5 lines) (cherry picked from commit 9857adb) Signed-off-by: Paul Donald <newtwen+github@gmail.com> openwrt#360 Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The semantics and logic are preserved, and hopefully readability is improved by breaking up some of those monster if conditions.
@Alphix @Noltari