dhcpv6: allow INFO_REQ for SLAAC only#365
Closed
Noltari wants to merge 1 commit intoopenwrt:masterfrom
Closed
Conversation
Allow DHCPV6_MSG_INFORMATION_REQUEST for RA (SLAAC) only configurations. Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Contributor
|
But shouldn't it be like that? Now this forces DHCPv6 to run if RA is in server mode. We should rather disable the O flag if DHCPv6 is off, no? |
Contributor
There is no one-to-one correspondence between the flags in the RA and whether we offer DHCP services, because there could still be a DHCP server on the same subnet, but it could be on a different host... |
Contributor
|
Then I think it's correct as is. I considered the possibility that radvd is running elsewhere and odhcpd can't control that aspect. I merely mean that if we have control over the O flag that we send, we can disable that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow DHCPV6_MSG_INFORMATION_REQUEST for RA (SLAAC) only configurations.
@Alphix @systemcrash not sure if this is correct, but I've noticed that clients keep sending DHCPv6 Information Requests to odhcpd server and it never replies since DHCPv6 is considered as disabled if it's configured as RA only (no DHCPv6 managed mode).
Marking as draft for now...