netlink: clean up sockets, close files#367
Merged
openwrt-bot merged 1 commit intoopenwrt:masterfrom Jan 10, 2026
Merged
Conversation
Closed
Contributor
Author
|
ping @Alphix |
Contributor
|
Question: |
systemcrash
force-pushed
the
exit_cleanup
branch
from
78aead9 to
b684acf
Compare
Contributor
Author
|
I have no preference either way - but the init routines are likewise not static because they're called from |
Contributor
Author
|
Welp, I've taken it for a quick spin and nothing exploded :) |
Contributor
Author
|
At your leisure, then, @Noltari |
Contributor
|
Might be a silly question, but why are we bothering with cleanup on exit? Is it because you get spam in some profiling tool otherwise? |
Contributor
Author
|
Just good practice, if nothing else. |
Sockets are handled for most usage paths, except for shutdown. Handle those at shutdown. Signed-off-by: Paul Donald <newtwen+github@gmail.com> Link: openwrt#367 Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Member
|
Merged, thanks @systemcrash! |
Noltari
pushed a commit
to Noltari/odhcpd
that referenced
this pull request
Jan 25, 2026
Sockets are handled for most usage paths, except for shutdown. Handle those at shutdown. (cherry picked from commit 3cbbea8) Signed-off-by: Paul Donald <newtwen+github@gmail.com> Link: openwrt#367 Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sockets are handled for most usage paths, except for shutdown. Handle those at shutdown.
Closes #366