-
Notifications
You must be signed in to change notification settings - Fork 3.8k
aoa-proxy: add new package #22538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aoa-proxy: add new package #22538
Conversation
e926b5d to
b687400
Compare
|
The failing test seems to be related purely to the CI build system: zooming in: I don't think at this point, the actual package code or Makefile has been called yet. |
|
@jo-bitsch is this still relevant? If so you should squash your commits and add some commit description of this package. |
|
@GeorgeSapkin Thanks for reaching out. This is still relevant. I squashed the commits added a description with around the same level of detail I saw in other commits. If there is anything else I should change, please let me know. This is my first contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use aoa-proxy: add new package as commit subject.
It's a good idea to re-tests this in a snapshot.
And if there are any binaries, consider adding a CI test script. Check other projects for inspiration.
|
I followed your recommendations, but haven't checked how to add a CI test script. I'll do this over the coming week. |
|
@GeorgeSapkin I added a Actual functional tests require a USB connected Android device or a more involved USB virtualization setup, so I would only start adding that if you think this makes sense for here. Again: Thanks a lot for your help and guidance! |
|
The simple version check is enough. This just a sanity check that package produces a valid binary and all dependencies are installed correctly. |
|
You need to figure out why your CI test script is failing. |
|
@GeorgeSapkin Thanks for bearing with me. The issue was that the following: The test script checked the current version string is included in the output of I fixed this now and tested things again. |
|
I think I mispressed a button and can't reopen this PR right now. Since the pipeline failed because the recent change to the pipeline (4369bd6) requires the branch name to be not master. I opened a new PR #28184 from a better named branch. Thanks a lot for your guidance and bearing with me. |
Maintainer: Jó Ágila Bitsch @jo-bitsch jgilab@gmail.com
Compile tested: x86_64, generic, 23.05.0
Run tested: x86_64, generic, 23.05.0 in QEMU
Description:
This package aims to make working with Android Open Accessory (in
particular v1) as easy as possible.
It has 2 modes, depending on the state of the attached Android device.
(1) Announce mode: When the Android device is not yet in AOA mode, this
program announces its identity to the Android device and tries to
put it into AOA mode.
(2) Forwarding mode: Forward all input from stdin to the AOA device and
all output from AOA to stdout.
For OpenWrt, it includes a hotplug script and a service to automatically
announce itself and forward AOA traffic to SSH/dropbear.
It is particularly helpful for initially configuring a newly flashed OpenWrt
device if you need to set initial networking parameters.