Skip to content

Conversation

@jo-bitsch
Copy link

Maintainer: Jó Ágila Bitsch @jo-bitsch jgilab@gmail.com
Compile tested: x86_64, generic, 23.05.0
Run tested: x86_64, generic, 23.05.0 in QEMU

Description:
This package aims to make working with Android Open Accessory (in
particular v1) as easy as possible.
It has 2 modes, depending on the state of the attached Android device.
(1) Announce mode: When the Android device is not yet in AOA mode, this
program announces its identity to the Android device and tries to
put it into AOA mode.
(2) Forwarding mode: Forward all input from stdin to the AOA device and
all output from AOA to stdout.
For OpenWrt, it includes a hotplug script and a service to automatically
announce itself and forward AOA traffic to SSH/dropbear.

It is particularly helpful for initially configuring a newly flashed OpenWrt
device if you need to set initial networking parameters.

@jo-bitsch
Copy link
Author

The failing test seems to be related purely to the CI build system:
https://github.com/openwrt/packages/actions/runs/15135902006/job/42547515632?pr=22538#step:7:1174

#11 resolving provenance for metadata file
#11 DONE 0.0s
ImageID
Digest
Metadata
Reference
Check build summary support
Run docker run --rm \
  bash setup.sh
Error: Process completed with exit code 1.

zooming in:

  gpg: directory '/builder/.gnupg' created
  gpg: keybox '/builder/.gnupg/pubring.kbx' created
  gpg: key 1D53D1877742E911: 3 signatures not checked due to missing keys
  gpg: /builder/.gnupg/trustdb.gpg: trustdb created
  gpg: key 1D53D1877742E911: public key "OpenWrt Build System (Nitrokey3) <contact@openwrt.org>" imported
  gpg: key 28A39BC32074BE7A: 2 signatures not checked due to missing keys
  gpg: key 28A39BC32074BE7A: public key "OpenWrt Build System (PGP key for 19.07 release builds) <pgpsign-19.07@openwrt.org>" imported
  gpg: key CD84BCED626471F1: 2 signatures not checked due to missing keys
  gpg: key CD84BCED626471F1: public key "OpenWrt Build System (PGP key for unattended snapshot builds) <pgpsign-snapshots@openwrt.org>" imported
  gpg: key 88CA59E88F681580: public key "OpenWrt Build System (PGP key for 21.02 release builds) <pgpsign-21.02@openwrt.org>" imported
  gpg: key CD54E82DADB3684D: public key "OpenWrt Build System (GnuPGP key for 22.03 release builds) <pgpsign-22.03@openwrt.org>" imported
  gpg: Total number processed: 5
  gpg:               imported: 5
  gpg: no ultimately trusted keys found
  gpg: Signature made Tue 20 May 2025 11:39:28 AM UTC
  gpg:                using EDDSA key 92C561DE55AE6552F3C736B82B0151090606D1D9
  gpg: BAD signature from "OpenWrt Build System (Nitrokey3) <contact@openwrt.org>" [unknown]
Error: Process completed with exit code 1.

I don't think at this point, the actual package code or Makefile has been called yet.

@GeorgeSapkin
Copy link
Member

@jo-bitsch is this still relevant? If so you should squash your commits and add some commit description of this package.

@jo-bitsch
Copy link
Author

@GeorgeSapkin Thanks for reaching out. This is still relevant. I squashed the commits added a description with around the same level of detail I saw in other commits. If there is anything else I should change, please let me know. This is my first contribution.

Copy link
Member

@GeorgeSapkin GeorgeSapkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use aoa-proxy: add new package as commit subject.

It's a good idea to re-tests this in a snapshot.

And if there are any binaries, consider adding a CI test script. Check other projects for inspiration.

@GeorgeSapkin GeorgeSapkin changed the title aoa-proxy: add aoa-proxy package aoa-proxy: add new package Dec 20, 2025
@jo-bitsch
Copy link
Author

I followed your recommendations, but haven't checked how to add a CI test script. I'll do this over the coming week.

@jo-bitsch
Copy link
Author

@GeorgeSapkin I added a test.sh script that tests, that the binary is being built correctly. Is that what you meant?

Actual functional tests require a USB connected Android device or a more involved USB virtualization setup, so I would only start adding that if you think this makes sense for here.

Again: Thanks a lot for your help and guidance!

@GeorgeSapkin
Copy link
Member

The simple version check is enough. This just a sanity check that package produces a valid binary and all dependencies are installed correctly.

@GeorgeSapkin
Copy link
Member

You need to figure out why your CI test script is failing.

@jo-bitsch
Copy link
Author

@GeorgeSapkin Thanks for bearing with me.

The issue was that the following: The test script checked the current version string is included in the output of aoa-proxy --version. However, there was an issue with injecting the version, when compiled outside of a git repo, so the version string wasn't actually included.

I fixed this now and tested things again.

@jo-bitsch
Copy link
Author

I think I mispressed a button and can't reopen this PR right now. Since the pipeline failed because the recent change to the pipeline (4369bd6) requires the branch name to be not master.

Checking PR #22538
[fail] Pull request must come from a feature branch
       Actual: `master` branch

I opened a new PR #28184 from a better named branch. Thanks a lot for your guidance and bearing with me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants