iperf3: fix failing build of libiperf3 with ssl variant#22628
iperf3: fix failing build of libiperf3 with ssl variant#22628jonasjelonek wants to merge 1 commit intoopenwrt:masterfrom
Conversation
jonasjelonek
force-pushed
the
iperf3-fix-A
branch
from
b29045f to
5aa377f
Compare
jonasjelonek
changed the title
|
@BKPepe do you maybe have comments on this? |
jonasjelonek
force-pushed
the
iperf3-fix-A
branch
from
5aa377f to
a9e0d81
Compare
jonasjelonek
changed the title
jonasjelonek
force-pushed
the
iperf3-fix-A
branch
from
a9e0d81 to
9522fb5
Compare
|
@jonasjelonek still relevant? |
|
@GeorgeSapkin yes, the issue persists. Selecting iperf3-ssl and libiperf3 doesn't work as |
|
OK, well this is marked as draft for a while now. Are you planning on finishing this? |
jonasjelonek
changed the title
|
Luckily, there's not really something to finish. It still applies cleanly and fixes the issue. Not sure though if there are any objections against how I fixed this. |
jonasjelonek
force-pushed
the
iperf3-fix-A
branch
from
9522fb5 to
400c350
Compare
|
You should bump the |
This handles the SSL support for iperf3 as a configuration option rather than as a separate package (variant). This way an issue is fixed where libiperf3 fails to build when the ssl variant of iperf3 is selected. The build failure is caused by the '--disable-shared' that is added to CONFIGURE_ARGS when selecting the ssl variant. This prevents the build from generating the libiperf.so.*. Besides fixing the issue, this also allows to have shared libiperf3 with SSL support and avoids the need to statically compile iperf3-ssl. Signed-off-by: Jonas Jelonek <jelonek.jonas@gmail.com>
jonasjelonek
force-pushed
the
iperf3-fix-A
branch
from
400c350 to
87d67d8
Compare
|
I'm not using iperf3 so somebody else will need to check this. But after taking a brief look, does this change imply that if |
If there's no way to set such config operation when using firmware selector/image builder, then yes. One of the reason I had this as an RFC/draft at first. I'm also fine to drop this completely. I had this PR and even an issue some time ago with barely any replies. So it seems, no one actually came across it aka no need to fix something. |
harrydleung
left a comment
harrydleung
left a comment
There was a problem hiding this comment.
I've tested this and it works well on 24.10.5. I think this should be backported to the openwrt-24.10 branch as well.
3 participants
Maintainer: @nbd168
Compile tested: aarch64_cortex-a53 (BananaPi R64) + x86/64 (APU2C4), OpenWrt snapshot
Run tested: aarch64_cortex-a53 (BananaPi R64) + x86/64 (APU2C4), OpenWrt snapshot
Description:
In my PR #22516 and in the follow-up issue #22566 I opened, I already described the issue itself.
TLDR: Building
libiperf3fails wheniperf3-sslis selected becauseiperf3-ssladds--disable-sharedto CONFIGURE_ARGS which prevents generatinglibiperf.so.*file, which is obviously necessary for libiperf3.My proposed changes fix the issue and in addition also allow to have a shared libiperf3 with SSL support, which afaik was not possible before. Instead of having separate package variants for with/without SSL support, let's just do that with a config option that can be chosen. Any objections to this?