shairport-sync: pipe audio backend support enabled

[davidandreoletti]

Maintainer: @mikebrady / @thess

Compile tested:

• arch: armv8
• model: NanoPi R4S
• OpenWRT version: 23.05

Run tested:

• arch: armv8
• model: NanoPi R4S
• OpenWRT version: OpenWrt 23.05.2 r23630-842932a63d / LuCI openwrt-23.05 branch git-23.306.39416-c86c256
• tests:

-- [x] shairport-sync 4.3.2 installed on NanoPi R4S
-- [x] shairport-sync -V reports 'pipe' support

root@test-router-hw1:~# /usr/bin/shairport-sync -V
4.3.2-libdaemon-OpenSSL-Avahi-ALSA-pipe-soxr-metadata-sysconfdir:/etc

-- [x] shairport-sync to write to default pipe on NanoPi R4S with UCI's shairport-sync's 'pipe-name' set to /etc/shairport-sync-audio

root@test-router-hw1:~# ls -alh /tmp/shairport-sync-*
prw-rw-rw-    1 root     root           0 Dec 20 11:58 /tmp/shairport-sync-audio
prw-rw-rw-    1 root     root           0 Dec 20 11:58 /tmp/shairport-sync-metadata
-rw-------    1 root     root      108.9K Dec 20 11:58 /tmp/shairport-sync-openssl_4.3.2-0_aarch64_generic.ipk

1. Play audio on phone connected to shairport-sync's server instance

cat /tmp/shairport-sync-audio
**** full of gibberish symbol, as I expected :-) ****

Description:

• Enable pipe audio backend at compile time:
  • UCI's shairport-sync's pipe conf block is defined but has no effect without shairport-sync's pipe support.
  • On SBC with no sound card available (built-in or external) and without ALSA plugins support on OpenwRT (no package) to reroute a stream from shairport-sync's ALSA default output to a PulseAudio controlled Bluetooth sink , then pipe support is required to enable the following flow: shairport-sync -> named pipe -> owntone. See owntone: New package variant: owntone-pulseaudio #22942
  • diff: +746 bytes
    • shairport-sync-openssl_4.3.2-0_aarch64_generic.ipk without --pipe: 110806 bytes
    • shairport-sync-openssl_4.3.2-0_aarch64_generic.ipk with --pipe: 111552 bytes

[davidandreoletti]

@BKPepe PR ready for a second review round:

• PR description updated with additional rationales + list of changes.
• Code fixes implemented.

[davidandreoletti]

@BKPepe Do you think there should be 2 package variant instead ?

• shairport-sync (current)
• shairport-sync-pipe (additional)

[BKPepe]

Nope. Dne st 20. 12. 2023 15:02 uživatel David Andreoletti < ***@***.***> napsal:

…

@BKPepe <https://github.com/BKPepe> Do you think there should be 2 package variant instead ? - shairport-sync (current) - shairport-sync-pipe (additional) — Reply to this email directly, view it on GitHub <#22923 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA7IDVGH2BQGHBOY5GZHWULYKLVWXAVCNFSM6AAAAABA2RDWM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRUGUZDMOJUG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[davidandreoletti]

@BKPepe Builds issue (missing git signoff) is now resolved. It is ready for review again.

[BKPepe]

It is not ready for review. 1. In your PR, there are unrelated commits. It seems like badly rebased. 2. We dont need separate commit for PKG_RELEASE, squash it. 3. Commit description is still missing. However, I see some improvement in PR description, so, just copy paste it. :) Dont worry, we are still on track. I see some progress here. Dne čt 21. 12. 2023 9:41 uživatel David Andreoletti < ***@***.***> napsal:

…

@BKPepe <https://github.com/BKPepe> Builds issue (missing git signoff) is now resolved. It is ready for review again. — Reply to this email directly, view it on GitHub <#22923 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA7IDVCANWLCRZXBFWR7QG3YKPY4JAVCNFSM6AAAAABA2RDWM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRVHA3TANRZHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[davidandreoletti]

@BKPepe

1. Non shairport-sync related commits removed from the PR/branch
2. Squashed
3. Copy-pasted description into top commit

[BKPepe]

Almost we are there. Now, your commit with update to 4.3.2 in its commit description contains smth about pipe audio backend, which is completely unrelated and should be in yours 2nd commit. Dne čt 21. 12. 2023 12:01 uživatel David Andreoletti < ***@***.***> napsal:

…

@BKPepe <https://github.com/BKPepe> 1. Non shairport-sync related commits removed from the PR/branch 2. Fixed 3. Copy-pasted description into top commit — Reply to this email directly, view it on GitHub <#22923 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA7IDVEKVIJV5TULCAYBECTYKQJJVAVCNFSM6AAAAABA2RDWM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRWGA2TSMBWHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[davidandreoletti]

@BKPepe Both commits have now the relevant description info.

[BKPepe]

Are you sure? :) Why in the update, there is a size difference, which should be imho in 2nd commit?

[davidandreoletti]

there is a size difference, which should be imho in 2nd commit?

@BKPepe Commit description reported packages have been built --with/without-pipe with 4.3.2, hence logical to report the relative size difference documented in 436ae68 commit since starting with that commit, one can rebuild both packages and get the same size difference.

Had the commit description reported packages been built with 3.3.9, then the size difference would have been stated in 9c9bd57.

Also, best to highlight the size difference for the upcoming release rather than a version which will not have --with-pipe enabled

[neheb]

Needs a rebase.

[davidandreoletti]

Needs a rebase.

@neheb done.

[neheb]

where's the PKG_RELEASE bump?

[davidandreoletti]

where's the PKG_RELEASE bump?

@neheb Now bumped again.

PS: It was present and then supersede by the rebase of 7391ca3 :-)

[davidandreoletti]

@neheb Do you have a rough timeframe for this to be merged (assuming no further actions needed) ?

[mikebrady]

Many thanks for all your work on this!