Merged
Conversation
- Update Telegraf to v1.37.0 Signed-off-by: Niklas Thorild <niklas@thorild.se>
Contributor
|
HOME is defined in the standard /etc/profile, so I wonder if your export change would possibly change that for some other process, too. So, do you need to export the HOME variable? I think that it would be enough to declare it in the uci-defaults context where telegraf config is immediately launched after defining the variable. In style of: |
avoid a non-critical error caused by getent not being installed Signed-off-by: Niklas Thorild <niklas@thorild.se>
c597102 to
52da48d
Compare
Contributor
Author
|
You're totally right. The change you suggested has been tested and applied. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: me
Description:
🧪 Run Testing Details
✅ Formalities