ddns-scripts: remove rework of OVH provider#28285
Closed
danielfdickinson wants to merge 1 commit intoopenwrt:openwrt-25.12from
Closed
ddns-scripts: remove rework of OVH provider#28285danielfdickinson wants to merge 1 commit intoopenwrt:openwrt-25.12from
danielfdickinson wants to merge 1 commit intoopenwrt:openwrt-25.12from
Conversation
This rework was unneeded, rather the fix in openwrt#28174 is required to resolve missing HTTP_AUTH support. The original issue in openwrt#27526 (unable to update OVH DynHost IP address) was wrongly attributed to a change on the OVH API. As discussed in openwrt#28172 the API continues to work for 24.10.5 system, as well as users using wget-ssl. The changes in openwrt#27561 and the followup fix openwrt#27694 add unnecessary dependencies which are heavier than the actually needed minimum. Therefore return the OVH provider to the previous state, and let openwrt#28174 resolved the issue. Note that PKG_RELEASE is 82 vs 84 in master, due to other not cherry-picked commits. Signed-off-by: Daniel F. Dickinson <dfdpublic@wildtechgarden.ca> (cherry picked from commit 01ac296)
Contributor
Author
|
Cherry picked per #28175 (comment) Run testing being prepared. |
Contributor
Author
|
@feckert Run testing successful (ovh.com DynHost updates properly with and without cURL on the system). |
Member
|
I have checked the master branch, and the changes of PKG_RELEASE 82 and 83 can also be backportet to the openwrt-25.12 Branch. This branch is still an RC. So I staged a PR with the latest changes form master against openwrt-25.12. @danielfdickinson Thanks for the PR but I would prefer to be in sync with master in the current rc phase. |
Contributor
Author
|
No problem. Thank you for updating this! |
danielfdickinson
deleted the
pr-cherry-pick-ddns-script-remove-ovh-rework
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: @feckert
Description:
This rework was unneeded, rather the fix in
#28174 is required to resolve missing HTTP_AUTH support.
The original issue in #27526 (unable to update OVH DynHost IP address) was wrongly attributed to a change on the OVH API. As discussed in
#28172 the API continues to work for 24.10.5 system, as well as users using wget-ssl.
The changes in #27561 and the followup fix #27694 add unnecessary dependencies which are heavier than the actually needed minimum.
Therefore return the OVH provider to the previous state, and let #28174 resolved the issue.
Note that PKG_RELEASE is 82 vs 84 in master due to other, not cherry-picked, commits.
(cherry picked from commit 01ac296)
🧪 Run Testing Details
Update of an ovh.com DynHost verified with cURL.
✅ Formalities