Net snmp distro extend

[perceival]

📦 Package Details

Maintainer: @
_{(You can find this by checking the history of the package Makefile.)}

Description:

---

🧪 Run Testing Details

• OpenWrt Version:
• OpenWrt Target/Subtarget:
• OpenWrt Device:

---

✅ Formalities

• I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

If your PR contains a patch:

• It can be applied using git am
• It has been refreshed to avoid offsets, fuzzes, etc., using

  make package/<your-package>/refresh V=s

• It is structured in a way that it is potentially upstreamable
  _{(e.g., subject line, commit description, etc.)
  We must try to upstream patches to reduce maintenance burden.}

[feckert]

Can you please remove this commit 623334e from this PR See my comments in #28774
And the same applies here. This is a configuration setting.
The user can do whatever they like.

[perceival]

Can you please remove this commit 623334e from this PR See my comments in #28774 And the same applies here. This is a configuration setting. The user can do whatever they like.

@feckert br-lan is a default therefore eth0 is going to far less often work then br-lan but anyway I have removed it. Also fixed quoting.

[hnyman]

You have a merge commit there. That should be removed. Likely via squashing with git rebase.
(refreshing with a merge from master is not the right way. "git rebase master" would be more optimal)

[perceival]

You have a merge commit there. That should be removed. Likely via squashing with git rebase.
(refreshing with a merge from master is not the right way. "git rebase master" would be more optimal)

Cheers Hannu!

Should be better now.

Regards,
percy

[perceival]

@feckert @hnyman could you please review?

[feckert]

Sorry, that still isn't right. You still have three commits in the PR, but there should only be one commit.

[perceival]

@feckert Indeed. Fixed now.

[feckert]

Can you please also update the body of the commit.
That doesn't look right

[perceival]

@feckert should be better already.

[feckert]

So I’ve taken the time to have a look at what you’re actually doing there.
The formalities are still not in correct.

• A “Signed-off-by” line with your full name and email address is missing.
• The commit message should not be longer than 75 characters.

I would retrieve the necessary information from /etc/os-release witch is a symlink to ../usr/lib/os-release. This information in this file are populated during the build process and is not normally modified. The information in /etc/banner are not persistent and may change.

[perceival]

@feckert Updated as requested: commit body cleaned up, Signed-off-by added with full name/email, and distro source switched from /etc/banner to /etc/os-release.

[feckert]

I do not see any changes?

[perceival]

@feckert My fault. Didn't check if push was succesful. Now should be visible.