[stablehlo][tosa] Fix for tosa dialect updates #2756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
this address the issue: #2751 (comment) |
This fixes up legalization passes for converting to/from tosa for tosa dialect changes - tosa rescale has multiplier, shift, input_zp, output_zp changed from attribute to operands with specific type requirements - tosa rescale attribute "double_round" changed to "rounding_mode" - tosa negate has additional input_zp and output_zp operands - tosa const attribute name changed from "value" to "values" Signed-off-by: Tai Ly <[email protected]> Change-Id: I38d31eacde961e7673bc3577dfbf55616608dc5e
Tai78641
force-pushed
the
pr_fix_for_tosa_updates
branch
from
9950dc3 to
73cbe57
Compare
GleasonK
approved these changes
Mar 24, 2025
Member
|
Thanks for the fixes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes up legalization passes for converting to/from tosa for tosa dialect changes