Added stablehlo divide fp to tosa reciprocal+mul conversion #2873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvish
force-pushed
the
vvish/feat/tosa_div_fp
branch
from
cc6379c to
ca945b3
Compare
GleasonK
approved these changes
Nov 14, 2025
vvish
force-pushed
the
vvish/feat/tosa_div_fp
branch
from
ca945b3 to
903812a
Compare
GleasonK
approved these changes
Nov 14, 2025
stablehlo/conversions/tosa/transforms/StablehloLegalizeToTosa.cpp
Outdated
Show resolved
Hide resolved
vvish
force-pushed
the
vvish/feat/tosa_div_fp
branch
from
903812a to
46d0634
Compare
Member
|
Looks like the failures in CI were all due to the github outage yesterday. Restarting CI PS, I've pinged you on discord to get some info to add you to the GH org so you don't need CI approval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to TOSA documentation for FP division "Floating point divide should use RECIPROCAL and MUL":
This PR implements conversion form stablehlo.divide into combination of TOSA ops.