FunctionArgTypeConverterFn
under BufferizationOptions
takes FunctionOpInterface
instead of func::FuncOp
#17935
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Hi! This PR is to synchronize with a recent LLVM/MLIR update (llvm/llvm-project#110322). The update replaces
func::FuncOp
withFunctionOpInterface
in many bufferization-related methods' signature. Now the signature ofFunctionArgTypeConverterFn
should containFunctionOpInterface
instead offunc::FuncOp
. Thank you very much!Related Changes in LLVM:
https://github.com/llvm/llvm-project/pull/110322/files#diff-0a1a3b3003580d05064692dc58271a17ca2d65ea69a11da1cb92f4102fbb1a20L262-L266