Skip to content

Fix: prevent panic in YurtAppSet status for StatefulSet workloads #2503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yashika0724 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: prevent panic in YurtAppSet status for StatefulSet workloads #2503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions pkg/yurtmanager/controller/yurtappset/yurt_app_set_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,12 +628,29 @@ func (r *ReconcileYurtAppSet) conciliateYurtAppSetStatus(
// calculate yas current status
readyWorkloads, updatedWorkloads := 0, 0
for _, workload := range curWorkloads {
workloadObj := workload.(*appsv1.Deployment)
if workloadObj.Status.ReadyReplicas == workloadObj.Status.Replicas {
var readyReplicas, replicas, updatedReplicas int32
var hash string

switch w := workload.(type) {
case *appsv1.Deployment:
readyReplicas = w.Status.ReadyReplicas
replicas = w.Status.Replicas
updatedReplicas = w.Status.UpdatedReplicas
hash = workloadmanager.GetWorkloadHash(w)
case *appsv1.StatefulSet:
readyReplicas = w.Status.ReadyReplicas
replicas = w.Status.Replicas
updatedReplicas = w.Status.UpdatedReplicas
hash = workloadmanager.GetWorkloadHash(w)
default:
klog.Warningf("YurtAppSet[%s/%s] unknown workload type: %T", yas.GetNamespace(), yas.GetName(), workload)
Copy link
Member

@vie-serendipity vie-serendipity Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to include the workload's name and namespace in the logs?

Copy link
Author

@Yashika0724 Yashika0724 Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to include the workload's name and namespace in the logs?

That makes sense, including the workload name and namespace would improve debugging and log clarity. I’ll update the warning log to include those fields.
Thanks for the suggestion!

continue
}

if readyReplicas == replicas {
readyWorkloads++
}
if workloadmanager.GetWorkloadHash(workloadObj) == expectedRevision.GetName() &&
workloadObj.Status.UpdatedReplicas == workloadObj.Status.Replicas {
if hash == expectedRevision.GetName() && updatedReplicas == replicas {
updatedWorkloads++
}
}
Expand Down
Loading