fix: log yurt-manager Execute() error before exit#2504
fix: log yurt-manager Execute() error before exit#2504shiavm006 wants to merge 1 commit intoopenyurtio:masterfrom
Conversation
Adds a klog error message prior to os.Exit(1) to improve production debugging.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2504 +/- ##
==========================================
- Coverage 44.09% 44.08% -0.01%
==========================================
Files 399 399
Lines 26554 26555 +1
==========================================
- Hits 11710 11708 -2
- Misses 13782 13784 +2
- Partials 1062 1063 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
the test passed locally tho i dont think so it related to the pr |
|
@shiavm006 Please pay attention to the inadequate unit test coverage. |
Regarding unit test coverage |
|
I've manually tested the error logging path, and the underlying command execution is already covered by existing tests @zyjhtangtang |



Description
How I tested it