Skip to content

FreeBSD: zfs_getpages: Don't zero freshly allocated pages #17851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2025
+13 −1
Merged

FreeBSD: zfs_getpages: Don't zero freshly allocated pages #17851

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion module/os/freebsd/zfs/zfs_vnops_os.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4225,8 +4225,20 @@ zfs_getpages(struct vnode *vp, vm_page_t *ma, int count, int *rbehind,

zfs_vmobject_wlock(object);
(void) vm_page_grab_pages(object, OFF_TO_IDX(start),
VM_ALLOC_NORMAL | VM_ALLOC_WAITOK | VM_ALLOC_ZERO,
VM_ALLOC_NORMAL | VM_ALLOC_WAITOK,
ma, count);
if (!vm_page_all_valid(ma[count - 1])) {
/*
* Later in this function, we copy DMU data to
* invalid pages only. The last page may not be
* entirely filled though, if the file does not
* end on a page boundary. Therefore, we zero
* that last page here to make sure it does not
* contain garbage after the end of file.
*/
ASSERT(vm_page_none_valid(ma[count - 1]));
vm_page_zero_invalid(ma[count - 1], FALSE);
}
zfs_vmobject_wunlock(object);
}
if (blksz == zp->z_blksz)
Expand Down
Loading