Skip to content

Commit cb22a89

Browse files
author
renaud gaudin
committed
Removed duplicated bits
- moved flake8 config to setup.cfg to save a file - removed --profile param on isort in tasks as setup.cfg specifies it - removed --max-line-length param on flake8 in tasks as setup.cfg specifies it - removed Pipfile as dev dependencies are specified in dev-requirements.txt - updated .gitignore to new file naming and added placeholder for dev files
1 parent 17f806d commit cb22a89

File tree

5 files changed

+14
-27
lines changed

5 files changed

+14
-27
lines changed

.flake8

Lines changed: 0 additions & 2 deletions
This file was deleted.

.gitignore

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,11 @@ libzim_linux-*/
2424

2525
# Autogenerated files
2626
wrapper.*.so
27-
libzim/wrapper.cpp
28-
libzim/wrapper.h
29-
libzim/wrapper_api.h
27+
libzim/libzim.cpp
28+
libzim/libzim.h
29+
libzim/libzim_api.h
30+
31+
# custom-dev
32+
Pipfile
33+
.dev
34+
.env

Pipfile

Lines changed: 0 additions & 17 deletions
This file was deleted.

setup.cfg

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,3 +46,6 @@ test_requires =
4646

4747
[isort]
4848
profile = black
49+
50+
[flake8]
51+
max-line-length = 88

tasks.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@
77

88
from invoke import task
99

10-
MAX_LINE_LENGTH = 88
11-
1210

1311
@task
1412
def build_ext(c):
@@ -37,17 +35,17 @@ def install_dev(c):
3735

3836
@task
3937
def check(c):
40-
c.run("isort --profile=black --check-only .")
38+
c.run("isort --check-only .")
4139
c.run("black --check .")
4240
c.run('echo "one pass for show-stopper syntax errors or undefined names"')
4341
c.run("flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics")
4442
c.run('echo "one pass for small stylistic things"')
45-
c.run(f"flake8 . --count --max-line-length={MAX_LINE_LENGTH} --statistics")
43+
c.run("flake8 . --count --statistics")
4644

4745

4846
@task
4947
def lint(c):
50-
c.run("isort --profile=black .")
48+
c.run("isort .")
5149
c.run("black .")
5250
c.run("flake8 .")
5351

0 commit comments

Comments
 (0)