Skip to content

return builder_id in create/update response#1071

Merged
audiodude merged 4 commits intoopenzim:mainfrom
lumpy72006:main
Feb 3, 2026
Merged

return builder_id in create/update response#1071
audiodude merged 4 commits intoopenzim:mainfrom
lumpy72006:main

Conversation

@lumpy72006
Copy link
Contributor

this addresses #1069

@audiodude
Copy link
Member

I t looks like you didn't run the tests. Please update those as well.

@lumpy72006
Copy link
Contributor Author

I've done that now 🙂

@lumpy72006 lumpy72006 requested a review from audiodude February 3, 2026 04:35
Copy link
Member

@audiodude audiodude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know whether you'd like to fix the last nit. If not I'll run CI.

@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.79%. Comparing base (14b1b94) to head (cc59b33).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1071   +/-   ##
=======================================
  Coverage   92.79%   92.79%           
=======================================
  Files          74       74           
  Lines        4289     4291    +2     
=======================================
+ Hits         3980     3982    +2     
  Misses        309      309           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@audiodude audiodude merged commit 19c6958 into openzim:main Feb 3, 2026
6 checks passed
@audiodude
Copy link
Member

CI is clean, thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants