Skip to content

fix logging inconsistencies#1130

Merged
audiodude merged 1 commit intoopenzim:mainfrom
Best2Two:fix-logging
Mar 25, 2026
Merged

fix logging inconsistencies#1130
audiodude merged 1 commit intoopenzim:mainfrom
Best2Two:fix-logging

Conversation

@Best2Two
Copy link
Copy Markdown
Contributor

fixes #1129

@Best2Two
Copy link
Copy Markdown
Contributor Author

@audiodude, this is the last one for my work yesterday

Copy link
Copy Markdown
Member

@audiodude audiodude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, good catch!

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.78%. Comparing base (cc552ce) to head (eb0639d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
wp1/logic/builder.py 50.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (66.66%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1130   +/-   ##
=======================================
  Coverage   92.78%   92.78%           
=======================================
  Files          74       74           
  Lines        4311     4311           
=======================================
  Hits         4000     4000           
  Misses        311      311           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@audiodude audiodude merged commit 538bfe2 into openzim:main Mar 25, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix inconsistent logging usage

2 participants