This repository was archived by the owner on Oct 23, 2019. It is now read-only.
DO NOT MERGE: jitpack based zipkin build#212
Open
codefromthecrypt wants to merge 1 commit intomasterfrom
Open
Conversation
Author
|
@yyyogev you may also be interested in this. We've been toying with different ways to deliver pending changes to users easier so that our final builds are more stable and relevant. |
Author
|
ps those building will need to use something like this as nothing in the dockerfile changes from builld-to-build |
codefromthecrypt
force-pushed
the
jitpack
branch
from
8bb0581 to
7d66954
Compare
codefromthecrypt
force-pushed
the
jitpack
branch
from
9f4ebab to
dbc697b
Compare
codefromthecrypt
force-pushed
the
jitpack
branch
2 times, most recently
from
f7cede5 to
a667447
Compare
So, we should figure out how to cut images mostly for master, but possibly for feature branches also. This is just a dockerfile edit, but maybe helpful to start elaborating what something real might look like.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, we should figure out how to cut images mostly for master, but
possibly for feature branches also. This is just a dockerfile edit, but
maybe helpful to start elaborating what something real might look like.
cc @openzipkin/devops-tooling