Conversation
plorenz
force-pushed
the
min-underlays
branch
from
524a957 to
4123bde
Compare
…ess of underlay type. Fixes #226
plorenz
force-pushed
the
min-underlays
branch
from
4123bde to
52608d8
Compare
| } | ||
|
|
||
| chId := underlay.ConnectionId() | ||
| isFirst, _ := Headers(underlay.Headers()).GetBoolHeader(IsFirstGroupConnection) |
Member
There was a problem hiding this comment.
Who sets this? Seems odd to be in channel if channel doesn't also set it.
Member
There was a problem hiding this comment.
Oh I see, you didn't add this you moved it from below.
andrewpmartinez
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.