MultiListener doesn't always close underlays that aren't accepted #230#231
Merged
MultiListener doesn't always close underlays that aren't accepted #230#231
Conversation
multi_listener.go
Outdated
Comment on lines
81
to
93
| if err != nil || mc == nil { | ||
| if mc == nil && err == nil { | ||
| err = errors.New("multi-channel factory returned nil") | ||
| } | ||
| log.WithError(err).Error("failed to create multi-underlay channel") | ||
| if closeErr := underlay.Close(); closeErr != nil { | ||
| log.WithError(closeErr).Error("error closing underlay") | ||
| } | ||
| } else { | ||
| self.lock.Lock() | ||
| self.channels[chId] = mc | ||
| self.lock.Unlock() | ||
| } |
Member
There was a problem hiding this comment.
This sucks to read.
nil or nil to both nil or not.
Member
Author
There was a problem hiding this comment.
I un-nested it to make it clearer
andrewpmartinez
approved these changes
Feb 27, 2026
plorenz
force-pushed
the
fix-missing-closes
branch
from
51d3915 to
6f04187
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.