Skip to content

release notes and hard errors on no TOTP handler breaks partial auth events #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2025
Merged

release notes and hard errors on no TOTP handler breaks partial auth events #824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
# Release notes 1.2.10

## What's New

* HA Posture Check Support

## HA Posture Check Support

Upcoming releases of the OpenZiti controller and routers will support posture checks that are enforced at the router
level. This release adds support for that workflow when it is available.


## Issues Fixed and Dependency Updates

* github.com/openziti/sdk-golang: [v1.2.9 -> v1.2.10](https://github.com/openziti/sdk-golang/compare/v1.2.9...v1.2.10)

# Release notes 1.2.9

## Issues Fixed and Dependency Updates
Expand Down
2 changes: 1 addition & 1 deletion ziti/sdkinfo/build_info.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ziti/ziti.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1288,7 +1288,7 @@ func (context *ContextImpl) handleAuthQuery(authQuery *rest_model.AuthQueryDetai
if *authQuery.Provider == rest_model.MfaProvidersZiti {

if context.ListenerCount(EventMfaTotpCode) == 0 {
return errors.New("no MFA TOTP code providers have been added via zitiContext.Events().AddMfaTotpCodeListener()")
pfxlog.Logger().Warn("no MFA TOTP code providers have been added via zitiContext.Events().AddMfaTotpCodeListener()")
Copy link
Member

@dovholuknf dovholuknf Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it didn't make sense to do this after emitting the event below? i assume this change was to still permit the event to be emitted, right? seems like you could do this after that emit and still return the error? just figured i'd ask

Copy link
Member Author

@andrewpmartinez andrewpmartinez Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It gunks up assumptions in other places I don't have time to fix now. It was originally a warning error and in my hubris I thought an error would be so much better.

}

context.Emit(EventMfaTotpCode, authQuery, MfaCodeResponse(context.authenticateMfa))
Expand Down
Loading