for openziti/ziti#3496 adds TOTP enrollment support during OIDC auth#889
Open
andrewpmartinez wants to merge 4 commits intomainfrom
Open
for openziti/ziti#3496 adds TOTP enrollment support during OIDC auth#889andrewpmartinez wants to merge 4 commits intomainfrom
andrewpmartinez wants to merge 4 commits intomainfrom
Conversation
Member
andrewpmartinez
commented
Mar 6, 2026
andrewpmartinez
commented
- adds TotpEnrollmentResult, TotpEnrollmentProvider, TotpEnrollmentProviderFunc types to edge-apis/totp.go
- detects unenrolled TOTP in handlePrimaryAndSecondaryAuth and routes to handleTotpEnrollment in clients_shared.go
- threads TotpEnrollmentProvider through ZitiEdgeClient and ZitiEdgeManagement
- adds EventMfaTotpEnrollment constant and AddMfaTotpEnrollmentListener to the Eventer interface and ContextImpl
- adds MfaTotpEnrollmentResponse type and wires TotpEnrollmentProviderFunc into ApiClientConfig in contexts.go
- adds Authorize() for edge oidc initial auth request tests
plorenz
approved these changes
Mar 7, 2026
- adds TotpEnrollmentResult, TotpEnrollmentProvider, TotpEnrollmentProviderFunc types to edge-apis/totp.go - detects unenrolled TOTP in handlePrimaryAndSecondaryAuth and routes to handleTotpEnrollment in clients_shared.go - threads TotpEnrollmentProvider through ZitiEdgeClient and ZitiEdgeManagement - adds EventMfaTotpEnrollment constant and AddMfaTotpEnrollmentListener to the Eventer interface and ContextImpl - adds MfaTotpEnrollmentResponse type and wires TotpEnrollmentProviderFunc into ApiClientConfig in contexts.go - adds Authorize() for edge oidc initial auth request tests
andrewpmartinez
force-pushed
the
fix.openziti.ziti.3496.totp-enrollment-during-oidc
branch
from
e917e88 to
c9685d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.