Skip to content

Conversation

@Biki-das
Copy link
Contributor

this piece of code seemed a little odd and i think this can be writen in this manner

@Biki-das
Copy link
Contributor Author

@rentallect please review

@ghost
Copy link

ghost commented Oct 22, 2021

Changes to your CodeSee Architecture Map:

View a CodeSee Map of these changes

View this PR diagram as an interactive map

View more CodeSee Maps

Legend

CodeSee Map Legend

@Biki-das Biki-das changed the title improved code fix: improper expression pattern Oct 25, 2021
function ZitiAgent (opts) {

if (!(this instanceof ZitiAgent)) return new ZitiAgent(opts);
if ('string' == typeof opts) opts = url.parse(opts);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is nothing "improper" about this code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants