feat: support multiple AWS key types #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougkirkley
force-pushed
the
feat/add-key-type-configuration
branch
2 times, most recently
from
bc19fde to
7988e66
Compare
Author
|
@Agalin Can I get a review on this? |
Collaborator
|
I was sick the whole week, sorry for the delay. 🙂 CI wants your commit not to start with upper case after Considering CRD changes, I believe you also need to regenerate at least the manifest.yaml file ( |
Signed-off-by: Douglass Kirkley <[email protected]>
dougkirkley
force-pushed
the
feat/add-key-type-configuration
branch
from
7988e66 to
c59e61a
Compare
dougkirkley
changed the title
Agalin
approved these changes
Oct 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
keyTypefield to S3Credentials to allow users to backup to AWS compatible environments without static AWS credentials. This will allow AWS IRSA and Pod Identity Webhook methods in EKS to authenticate with S3. This defaults tosharedwhich allows backwards compatibility with the current access key method via secrets.Closes #38