feat: use proper gRPC status codes for WAL errors#67
Open
ermakov-oleg wants to merge 1 commit intooperasoftware:mainfrom
Open
feat: use proper gRPC status codes for WAL errors#67ermakov-oleg wants to merge 1 commit intooperasoftware:mainfrom
ermakov-oleg wants to merge 1 commit intooperasoftware:mainfrom
Conversation
Port of upstream PR cloudnative-pg#549. WAL not found returns NotFound, end of WAL stream returns OutOfRange, missing permissions returns FailedPrecondition. Signed-off-by: ermakov-oleg <ermakovolegs@gmail.com>
ermakov-oleg
force-pushed
the
feat/grpc-error-codes
branch
from
89009fa to
8e758fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port of upstream #549
Problem: The plugin returned generic gRPC errors (wrapping
errors.New()) for cases that have well-defined semantics. The CNPG operator could not distinguish a missing WAL (expected during restore) from a real error, and treated S3 permission errors the same as infrastructure failures.Fix: Replaced custom error types with proper gRPC status codes:
codes.NotFound— WAL file not found in object store (replaces customwalNotFoundErrortype)codes.OutOfRange— end of WAL stream reached during restore (waserrors.New)codes.FailedPrecondition— backup credentials don't have required S3 permissions yet (waserrors.New)This allows the CNPG operator to handle each case appropriately: retry on FailedPrecondition, stop on OutOfRange, skip on NotFound.