-
Notifications
You must be signed in to change notification settings - Fork 78
⚠️ Add extra info about SecurityContext field for CatalogSources SecurityContext #429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Add extra info about SecurityContext field for CatalogSources SecurityContext #429
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #429 +/- ##
=======================================
Coverage 39.79% 39.79%
=======================================
Files 56 56
Lines 5450 5450
=======================================
Hits 2169 2169
Misses 3127 3127
Partials 154 154 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cc66093
to
5805b27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with this. But, it would also be good to double check with @joelanford.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5805b27
to
eaccbc3
Compare
catalog images, which can not run in `restricted` mode, the SecurityContextConfig should be set to `legacy`. | ||
Important, Catalog Sources built with OPM versions < v1.21.0 will not be able to run in `restricted` mode, and should | ||
be set to `legacy`. Catalog Sources built with OPM versions >= v1.21.0 will be able to run in `restricted` mode, | ||
OLM releases >= v1.32.0 can only accept the restricted mode and will not accept the legacy mode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found an issue that would be v0.32 and not v1.32
But I want the agreements and the right version to change this one. operator-framework/operator-lifecycle-manager#3526 (comment)
Due to OLMv0 being in maintenance mode, we decided not to introduce this breaking change. |
Motivated by: operator-framework/operator-lifecycle-manager#3526
/hold until we are able to get merged above ^ PR