Skip to content

fix: error being silenced during apply #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 10, 2024
Merged

fix: error being silenced during apply #395

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1c63d8d
fix: error being silenced during apply
timonwong Sep 19, 2024
8ad278b
add test
timonwong Sep 19, 2024
d4f8eee
Apply suggestions from code review
timonwong Sep 19, 2024
7e5adfc
fix lint
timonwong Sep 19, 2024
abbabcb
check error status message
timonwong Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/reconciler/reconciler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,13 +556,13 @@ type ControllerSetupFunc func(c ControllerSetup) error
// - Deployed - a release for this CR is deployed (but not necessarily ready).
// - ReleaseFailed - an installation or upgrade failed.
// - Irreconcilable - an error occurred during reconciliation
func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (result ctrl.Result, err error) {
log := r.log.WithValues(strings.ToLower(r.gvk.Kind), req.NamespacedName)
log.V(1).Info("Reconciliation triggered")

obj := &unstructured.Unstructured{}
obj.SetGroupVersionKind(*r.gvk)
err := r.client.Get(ctx, req.NamespacedName, obj)
err = r.client.Get(ctx, req.NamespacedName, obj)
if apierrors.IsNotFound(err) {
log.V(1).Info("Resource %s/%s not found, nothing to do", req.NamespacedName.Namespace, req.NamespacedName.Name)
return ctrl.Result{}, nil
Expand Down