-
Notifications
You must be signed in to change notification settings - Fork 54
ROX-28223: Pause-reconcile handler #426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-28223: Pause-reconcile handler #426
Conversation
Co-authored-by: Marcin Owsiany <[email protected]>
perdasilva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgmt ^^ thank you!!
Signed-off-by: Per Goncalves da Silva <[email protected]>
|
@vladbologa I've taken the liberty of fixing up the lint complaints - I hope that's ok. If it's green, I'll merge. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #426 +/- ##
==========================================
- Coverage 85.06% 78.47% -6.60%
==========================================
Files 19 31 +12
Lines 1346 2518 +1172
==========================================
+ Hits 1145 1976 +831
- Misses 125 451 +326
- Partials 76 91 +15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR upstreams a feature from the https://github.com/stackrox/helm-operator fork used by ACS (Advanced Cluster Security)
Source commit: stackrox/helm-operator@30a1ac3
Original PR: stackrox/helm-operator#29
The PR implements support for a "pause reconcile" handler, which determines if the reconcile should be paused for a given custom resource. Also provided is an implementation for such a handler, that allows pausing reconciliation via a custom annotation that must be added to the CR. If this annotation is set to
truethen the operator does not reconcile the CR.