Skip to content

Conversation

@vladbologa
Copy link
Contributor

@vladbologa vladbologa commented Feb 24, 2025

This PR upstreams a feature from the https://github.com/stackrox/helm-operator fork used by ACS (Advanced Cluster Security)

Source commit: stackrox/helm-operator@30a1ac3
Original PR: stackrox/helm-operator#29

The PR implements support for a "pause reconcile" handler, which determines if the reconcile should be paused for a given custom resource. Also provided is an implementation for such a handler, that allows pausing reconciliation via a custom annotation that must be added to the CR. If this annotation is set to true then the operator does not reconcile the CR.

@vladbologa vladbologa changed the title ROX-28223: Pause-reconcile annotation ROX-28223: Pause-reconcile handler Mar 3, 2025
@vladbologa vladbologa requested a review from joelanford March 3, 2025 16:48
@vladbologa vladbologa requested a review from joelanford March 4, 2025 09:06
Copy link
Contributor

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt ^^ thank you!!

Signed-off-by: Per Goncalves da Silva <[email protected]>
@perdasilva
Copy link
Contributor

@vladbologa I've taken the liberty of fixing up the lint complaints - I hope that's ok. If it's green, I'll merge.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 84.37500% with 5 lines in your changes missing coverage. Please review.

Project coverage is 78.47%. Comparing base (08ab7fb) to head (195e0cb).
Report is 82 commits behind head on main.

Files with missing lines Patch % Lines
pkg/reconciler/reconciler.go 90.00% 2 Missing and 1 partial ⚠️
pkg/reconciler/internal/conditions/conditions.go 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (08ab7fb) and HEAD (195e0cb). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (08ab7fb) HEAD (195e0cb)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #426      +/-   ##
==========================================
- Coverage   85.06%   78.47%   -6.60%     
==========================================
  Files          19       31      +12     
  Lines        1346     2518    +1172     
==========================================
+ Hits         1145     1976     +831     
- Misses        125      451     +326     
- Partials       76       91      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@perdasilva perdasilva added this pull request to the merge queue Mar 13, 2025
Merged via the queue into operator-framework:main with commit 21768c8 Mar 13, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants