Skip to content

Commit 61d1f8a

Browse files
committed
refactor: use more appropriate method names
1 parent 2916b28 commit 61d1f8a

File tree

2 files changed

+25
-9
lines changed

2 files changed

+25
-9
lines changed

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/Metrics.java

Lines changed: 23 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,34 @@
11
package io.javaoperatorsdk.operator;
22

3+
import java.util.concurrent.TimeUnit;
4+
import java.util.function.ToDoubleFunction;
5+
import java.util.function.ToLongFunction;
6+
37
import io.fabric8.kubernetes.client.CustomResource;
48
import io.javaoperatorsdk.operator.api.Context;
59
import io.javaoperatorsdk.operator.api.DeleteControl;
610
import io.javaoperatorsdk.operator.api.ResourceController;
711
import io.javaoperatorsdk.operator.api.UpdateControl;
812
import io.javaoperatorsdk.operator.api.config.ControllerConfiguration;
9-
import io.micrometer.core.instrument.*;
13+
import io.micrometer.core.instrument.Clock;
14+
import io.micrometer.core.instrument.Counter;
15+
import io.micrometer.core.instrument.DistributionSummary;
16+
import io.micrometer.core.instrument.FunctionCounter;
17+
import io.micrometer.core.instrument.FunctionTimer;
18+
import io.micrometer.core.instrument.Gauge;
19+
import io.micrometer.core.instrument.Measurement;
20+
import io.micrometer.core.instrument.Meter;
21+
import io.micrometer.core.instrument.MeterRegistry;
22+
import io.micrometer.core.instrument.Timer;
1023
import io.micrometer.core.instrument.distribution.DistributionStatisticConfig;
1124
import io.micrometer.core.instrument.distribution.pause.PauseDetector;
12-
import io.micrometer.core.instrument.noop.*;
13-
import java.util.concurrent.TimeUnit;
14-
import java.util.function.ToDoubleFunction;
15-
import java.util.function.ToLongFunction;
25+
import io.micrometer.core.instrument.noop.NoopCounter;
26+
import io.micrometer.core.instrument.noop.NoopDistributionSummary;
27+
import io.micrometer.core.instrument.noop.NoopFunctionCounter;
28+
import io.micrometer.core.instrument.noop.NoopFunctionTimer;
29+
import io.micrometer.core.instrument.noop.NoopGauge;
30+
import io.micrometer.core.instrument.noop.NoopMeter;
31+
import io.micrometer.core.instrument.noop.NoopTimer;
1632

1733
public class Metrics {
1834
public static final Metrics NOOP = new Metrics(new NoopMeterRegistry(Clock.SYSTEM));
@@ -97,7 +113,7 @@ public DeleteControl timeControllerDelete(
97113
}
98114
}
99115

100-
public void timeControllerRetry() {
116+
public void incrementControllerRetriesNumber() {
101117

102118
registry
103119
.counter(
@@ -107,7 +123,7 @@ public void timeControllerRetry() {
107123

108124
}
109125

110-
public void timeControllerEvents() {
126+
public void incrementProcessedEventsNumber() {
111127

112128
registry
113129
.counter(

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/Operator.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,12 @@ public Operator(KubernetesClient k8sClient, ConfigurationService configurationSe
3737
DefaultEventHandler.setEventMonitor(new EventMonitor() {
3838
@Override
3939
public void processedEvent(String uid, Event event) {
40-
configurationService.getMetrics().timeControllerEvents();
40+
configurationService.getMetrics().incrementProcessedEventsNumber();
4141
}
4242

4343
@Override
4444
public void failedEvent(String uid, Event event) {
45-
configurationService.getMetrics().timeControllerRetry();
45+
configurationService.getMetrics().incrementControllerRetriesNumber();
4646
}
4747
});
4848
}

0 commit comments

Comments
 (0)