improve: naming target resource selector method #2546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Managed term is already used for dependent resources, for me this was confusing when I was checking this again, IMO this is a bit better name. |
Also add a sample usage. Signed-off-by: Attila Mészáros <[email protected]>
csviri
force-pushed
the
naming-select-res
branch
from
eeb5a29 to
642084d
Compare
Signed-off-by: Chris Laprun <[email protected]>
metacosm
approved these changes
Oct 9, 2024
metacosm
pushed a commit
that referenced
this pull request
Oct 10, 2024
metacosm
pushed a commit
that referenced
this pull request
Nov 5, 2024
metacosm
pushed a commit
that referenced
this pull request
Nov 6, 2024
csviri
added a commit
that referenced
this pull request
Nov 13, 2024
metacosm
pushed a commit
that referenced
this pull request
Nov 19, 2024
metacosm
pushed a commit
that referenced
this pull request
Nov 20, 2024
metacosm
pushed a commit
that referenced
this pull request
Nov 27, 2024
This was referenced Dec 3, 2024
csviri
added a commit
that referenced
this pull request
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, add a sample usage.