Skip to content

wip: attempt to simplify workflows handling #2566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 92 commits into from
Closed

wip: attempt to simplify workflows handling #2566

wants to merge 92 commits into from

Conversation

metacosm
Copy link
Collaborator

@metacosm metacosm commented Nov 5, 2024

  • refactor: remove now unneeded NameSetter interface
  • refactor: simplify workflow handling
  • refactor: initial work to combine ManagedWorkflow and regular one

csviri and others added 30 commits November 5, 2024 16:52
@csviri @metacosm
chore: set version to 5.0.0-SNAPSHOT (#2200)
bced288 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
improve: java version minimal 11, tested on 21 (#2207)
e9d1a1f 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
improve: remove deprecated EventFilter (#2208)
3e87067 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
docs: 5.0 migration guide skeleton (#2210)
a8c804d 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
improve: managed dependent reconciliation results not optional (#2212)
67c5fbd 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
improve: remove deprecated RetryConfiguration (#2211)
d3cdb05 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
feat: JDK client is now the default (#2235)
2a5c7ed 
Signed-off-by: Attila Mészáros <[email protected]>
@metacosm
fix: update SCM information (#2237)
2c302bd 
Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
feat: move name is directly to dependent resource (#2250)
82a16e4 
* feat: move name is directly to dependent resource

- use this name when throwing aggregate exception

Signed-off-by: Attila Mészáros <[email protected]>

* refactor to use a dedicated interface for setting the name

Signed-off-by: Attila Mészáros <[email protected]>

* refactor: add default implementation for name() (#2255)

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
format
b22d0ca 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
fix: test after rebase on master (#2270)
39c94d7 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
feat: use java 17 as baseline (#2271)
7c94f00 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
improve: matcher always considers metadata (#2273)
1bf5884 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
feat: API to check if next reconciliation is imminent (#2272)
7854f17 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
feat: Workflow extracted to a separate annotation (#2274)
dd609c1 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
fix: pom properties cleanup (#2280)
095f1c9 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
improve: remove EventSourceInitializer (#2257)
b6569fd 
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@metacosm
refactor: make loadFromProperties private (#2287)
0a92cc5 
Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
feat: distinguish resources based on desired state (#2252)
d24d4ca 
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
feat: explicit workflow invocation (#2289)
36e41fc 
Signed-off-by: Attila Mészáros <[email protected]>
@metacosm
feat: use ssa for status update by default from UpdateControl (#2278)
695c12f 
Signed-off-by: Chris Laprun <[email protected]>
@metacosm
refactor: make WorkflowSpec an interface (#2300)
d4b8f86 
Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
improve: replace current formatting plugins with spotless plugin (#2302)
6b258f3 
Signed-off-by: Attila Mészáros <[email protected]>
@metacosm
refactor: make ManagedWorkflowSupport public to be able to reuse it (#…
f674bfd 
…2308)

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
fix: package fix leader election sample (#2303)
e6e04f1 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
feat: remove resource discriminator (#2299)
435cb7c 
Signed-off-by: Attila Mészáros <[email protected]>
@metacosm
refactor: remove deprecated getTerminationTimeoutSeconds and associat…
54e1744 
…ed (#2297)

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
improve: additional logging to mysql schema e2e test (#2320)
ed703bc 
Signed-off-by: Attila Mészáros <[email protected]>
@metacosm
feat: handle clustered resource on secondary to primary mapper init (#…
e2acb18 
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
feat: using SSA for finalizer and primary patch (#2305)
1c8490d 
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
metacosm and others added 19 commits November 5, 2024 19:48
@metacosm
fix: wrong return type
a961efd 
Signed-off-by: Chris Laprun <[email protected]>
@csviri @metacosm
improve: cleaner throws Exception (#2527)
1f1fcb1 

Signed-off-by: Attila Mészáros <[email protected]>
@metacosm
feat: explicit node configuration in WorkflowBuilder (#2511)
bafbe09 
* feat: explicit node configuration in WorkflowBuilder

Fixes #2284

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename more appropriately

Signed-off-by: Chris Laprun <[email protected]>

---------

Signed-off-by: Chris Laprun <[email protected]>
@csviri @metacosm
fix: cleanup after rebase on main
11fedb6 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
feat: context getSecondary resource is activation condition aware (#2532
d2976b0 
)


Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
feat: e2e test to demonstrate namespace deletion problem fix (#2528)
b6fc034 

Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
docs: remove javadoc todos (#2541)
06627c5 
Signed-off-by: Attila Mészáros <[email protected]>
@10000-ki @metacosm
feat: print diff resource as yaml (#2542)
86bc91e
@csviri @metacosm
fix: integration test timeout issue (#2547)
348f96e 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
improve: naming target resource selector method (#2546)
6ac26d1
@bachmanity1 @metacosm
feat: improve diff logging (#2544)
9266295 
* imporve diff logging

Signed-off-by: bachmanity1 <[email protected]>

* compute diff only when actual doesn't match desired

Signed-off-by: bachmanity1 <[email protected]>

* slight improvements

Signed-off-by: bachmanity1 <[email protected]>

* increase context size

Signed-off-by: bachmanity1 <[email protected]>

* fix style

Signed-off-by: bachmanity1 <[email protected]>

* calculate diff only if debug is enabled

Signed-off-by: bachmanity1 <[email protected]>

* print actual resources when trace is enabled

Signed-off-by: bachmanity1 <[email protected]>

* use java-diff-utils

Signed-off-by: bachmanity1 <[email protected]>

* add unit tests

---------

Signed-off-by: bachmanity1 <[email protected]>
@metacosm
fix: race condition in workflow reconciler (#2549)
711076a 
Signed-off-by: Chris Laprun <[email protected]>
@metacosm
feat(ci): split integration tests execution by category (#2548)
548f158 
* feat(build): split ITs by category, parallel CRD generation

Also avoid generating CRDs when not needed by default, summarizes test
results.

* chore(deps): bump actions-setup-minikube to 2.13.0
* feat: default to use vertx client
* chore(ci): reduce tested combinations, only run client tests on baseapi
* fix: increase deletion timeout

---------

Signed-off-by: Chris Laprun <[email protected]>
@metacosm
refactor: rename method more appropriately (#2554)
0b9e762 
Signed-off-by: Chris Laprun <[email protected]>
@csviri @metacosm
improve: workflow builder naming (#2559)
7c29434
@metacosm
chore: adapt after rebase
ac22888 
Signed-off-by: Chris Laprun <[email protected]>
@metacosm
refactor: remove now unneeded NameSetter interface
c9fd929 
Signed-off-by: Chris Laprun <[email protected]>
@metacosm
refactor: simplify workflow handling
88b910d 
Signed-off-by: Chris Laprun <[email protected]>
@metacosm
refactor: initial work to combine ManagedWorkflow and regular one
dcbd856 
Signed-off-by: Chris Laprun <[email protected]>
@metacosm metacosm self-assigned this Nov 5, 2024
@metacosm metacosm requested review from csviri and xstefank November 5, 2024 20:41
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 5, 2024
@metacosm metacosm mentioned this pull request Nov 5, 2024
Closed
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2024
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metacosm
Copy link
Collaborator Author

Closed in favor of #2571

@metacosm metacosm closed this Nov 12, 2024
@metacosm metacosm deleted the clean-workflows-again branch November 12, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csviri csviri Awaiting requested review from csviri

@xstefank xstefank Awaiting requested review from xstefank

Assignees

@metacosm metacosm

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@metacosm @openshift-merge-robot @csviri @10000-ki @matteriben @bachmanity1