-
Notifications
You must be signed in to change notification settings - Fork 224
fix: RBAC typos in testsuite #2902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -368,35 +368,34 @@ Operator startOperator( | |
| } | ||
|
|
||
| private void setNoConfigMapAccess() { | ||
| applyClusterRole("rback-test-no-configmap-access.yaml"); | ||
| applyClusterRole("rbac-test-no-configmap-access.yaml"); | ||
| applyClusterRoleBinding(); | ||
| } | ||
|
|
||
| private void setNoCustomResourceAccess() { | ||
| applyClusterRole("rback-test-no-cr-access.yaml"); | ||
| applyClusterRole("rbac-test-no-cr-access.yaml"); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The typo 'rback' has been corrected to 'rbac' in the file path reference. Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||
| applyClusterRoleBinding(); | ||
| } | ||
|
|
||
| private void setFullResourcesAccess() { | ||
| applyClusterRole("rback-test-full-access-role.yaml"); | ||
| applyClusterRole("rbac-test-full-access-role.yaml"); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The typo 'rback' has been corrected to 'rbac' in the file path reference. Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||
| applyClusterRoleBinding(); | ||
| } | ||
|
|
||
| private void addRoleBindingsToTestNamespaces() { | ||
| var role = | ||
| ReconcilerUtils.loadYaml( | ||
| Role.class, this.getClass(), "rback-test-only-main-ns-access.yaml"); | ||
| ReconcilerUtils.loadYaml(Role.class, this.getClass(), "rbac-test-only-main-ns-access.yaml"); | ||
| adminClient.resource(role).inNamespace(actualNamespace).createOrReplace(); | ||
| var roleBinding = | ||
| ReconcilerUtils.loadYaml( | ||
| RoleBinding.class, this.getClass(), "rback-test-only-main-ns-access-binding.yaml"); | ||
| RoleBinding.class, this.getClass(), "rbac-test-only-main-ns-access-binding.yaml"); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The typo 'rback' has been corrected to 'rbac' in the file path reference. Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||
| adminClient.resource(roleBinding).inNamespace(actualNamespace).createOrReplace(); | ||
| } | ||
|
|
||
| private void applyClusterRoleBinding() { | ||
| var clusterRoleBinding = | ||
| ReconcilerUtils.loadYaml( | ||
| ClusterRoleBinding.class, this.getClass(), "rback-test-role-binding.yaml"); | ||
| ClusterRoleBinding.class, this.getClass(), "rbac-test-role-binding.yaml"); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The typo 'rback' has been corrected to 'rbac' in the file path reference. Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||
| adminClient.resource(clusterRoleBinding).createOrReplace(); | ||
| } | ||
|
|
||
|
|
@@ -418,7 +417,7 @@ private Namespace namespace(String name) { | |
| private void removeClusterRoleBinding() { | ||
| var clusterRoleBinding = | ||
| ReconcilerUtils.loadYaml( | ||
| ClusterRoleBinding.class, this.getClass(), "rback-test-role-binding.yaml"); | ||
| ClusterRoleBinding.class, this.getClass(), "rbac-test-role-binding.yaml"); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The typo 'rback' has been corrected to 'rbac' in the file path reference. Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||
| adminClient.resource(clusterRoleBinding).delete(); | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The typo 'rback' has been corrected to 'rbac' in the file path reference.
Copilot uses AI. Check for mistakes.