Skip to content

fix: patchResourceAndStatus on status patch should generate diff only from status #2973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 29, 2025
Merged

fix: patchResourceAndStatus on status patch should generate diff only from status #2973

merged 5 commits into from
Sep 29, 2025

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Sep 29, 2025

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 29, 2025
@csviri csviri linked an issue Sep 29, 2025 that may be closed by this pull request
UpdateControl.patchResourceAndStatus(primary) return error and can't patch status #2943
Closed
@csviri
fix test
423ba0f 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri csviri marked this pull request as ready for review September 29, 2025 08:18
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 29, 2025
@csviri csviri requested a review from xstefank September 29, 2025 08:18
@openshift-ci openshift-ci bot requested review from metacosm and xstefank September 29, 2025 08:18
@csviri
wip
e0bcba9 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri
wip
6c86b99 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri csviri requested a review from metacosm September 29, 2025 09:01
metacosm
metacosm approved these changes Sep 29, 2025
View reviewed changes
Copy link
Collaborator

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of using reflection here, as mentioned before. We probably need to revive the associated Fabric8 issue.

@csviri
Copy link
Collaborator Author

csviri commented Sep 29, 2025

Not a fan of using reflection here, as mentioned before. We probably need to revive the associated Fabric8 issue.

Sma here, that would be much nicer.

@csviri csviri merged commit 148dcb6 into main Sep 29, 2025
26 of 33 checks passed
@csviri csviri deleted the patch-resource-and-status branch September 29, 2025 11:33
@metacosm
Copy link
Collaborator

For reference, the Fabric8 issue: fabric8io/kubernetes-client#3586

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metacosm metacosm metacosm approved these changes

@xstefank xstefank Awaiting requested review from xstefank

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UpdateControl.patchResourceAndStatus(primary) return error and can't patch status
2 participants
@csviri @metacosm