refactor: fix suppressions

Signed-off-by: David Sondermann <[email protected]>

Author: Donnerbart

core/src/main/java/io/javaoperatorsdk/webhook/admission/mutation/AsyncDefaultAdmissionRequestMutator.java

@@ -32,6 +32,7 @@ public AsyncDefaultAdmissionRequestMutator(AsyncMutator<T> mutator, Cloner<T> cl
   }
 
   @Override
+  @SuppressWarnings("unchecked")
   public CompletionStage<AdmissionResponse> handle(AdmissionRequest admissionRequest) {
     var operation = Operation.valueOf(admissionRequest.getOperation());
     var originalResource = (T) getTargetResource(admissionRequest, operation);

core/src/main/java/io/javaoperatorsdk/webhook/admission/mutation/DefaultAdmissionRequestMutator.java

@@ -29,6 +29,7 @@ public DefaultAdmissionRequestMutator(Mutator<T> mutator, Cloner<T> cloner) {
   }
 
   @Override
+  @SuppressWarnings("unchecked")
   public AdmissionResponse handle(AdmissionRequest admissionRequest) {
     var operation = Operation.valueOf(admissionRequest.getOperation());
     var originalResource = (T) getTargetResource(admissionRequest, operation);

core/src/main/java/io/javaoperatorsdk/webhook/admission/validation/DefaultAdmissionRequestValidator.java

@@ -20,6 +20,7 @@ public DefaultAdmissionRequestValidator(Validator<T> validator) {
   }
 
   @Override
+  @SuppressWarnings("unchecked")
   public AdmissionResponse handle(AdmissionRequest admissionRequest) {
     var operation = Operation.valueOf(admissionRequest.getOperation());
     var originalResource = (T) getTargetResource(admissionRequest, operation);

core/src/main/java/io/javaoperatorsdk/webhook/clone/ObjectMapperCloner.java

@@ -8,6 +8,7 @@ public class ObjectMapperCloner<T> implements Cloner<T> {
   private final ObjectMapper objectMapper = new ObjectMapper();
 
   @Override
+  @SuppressWarnings("unchecked")
   public T clone(T object) {
     if (object == null) {
       return null;

core/src/main/java/io/javaoperatorsdk/webhook/conversion/AsyncConversionController.java

@@ -65,7 +65,7 @@ private CompletionStage<List<HasMetadata>> convertObjects(List<HasMetadata> obje
     });
   }
 
-  @SuppressWarnings({"unchecked", "rawtypes"})
+  @SuppressWarnings("unchecked")
   private CompletableFuture<HasMetadata> mapObject(HasMetadata resource, String targetVersion) {
     var sourceVersion = Utils.versionOfApiVersion(resource.getApiVersion());
     var sourceToHubMapper = mappers.get(sourceVersion);

core/src/main/java/io/javaoperatorsdk/webhook/conversion/ConversionController.java

@@ -45,13 +45,12 @@ public ConversionReview handle(ConversionReview conversionReview) {
     }
   }
 
-  @SuppressWarnings("unchecked")
   private List<HasMetadata> convertObjects(List<HasMetadata> objects, String targetVersion) {
     return objects.stream().map(r -> mapObject(r, targetVersion))
         .collect(Collectors.toList());
   }
 
-  @SuppressWarnings({"unchecked", "rawtypes"})
+  @SuppressWarnings("unchecked")
   private HasMetadata mapObject(HasMetadata resource, String targetVersion) {
     var sourceVersion = Utils.versionOfApiVersion(resource.getApiVersion());
     var sourceToHubMapper = mappers.get(sourceVersion);

…webhook/sample/AbstractEndToEndTest.java …sdk/webhook/sample/EndToEndTestBase.javasamples/commons/src/test/java/io/javaoperatorsdk/webhook/sample/AbstractEndToEndTest.java renamed to samples/commons/src/test/java/io/javaoperatorsdk/webhook/sample/EndToEndTestBase.java samples/commons/src/test/java/io/javaoperatorsdk/webhook/sample/AbstractEndToEndTest.java renamed to samples/commons/src/test/java/io/javaoperatorsdk/webhook/sample/EndToEndTestBase.java

@@ -22,6 +22,7 @@
 import static org.awaitility.Awaitility.await;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 
+@SuppressWarnings("deprecation")
 public class EndToEndTestBase {
 
   protected KubernetesClient client = new KubernetesClientBuilder().build();
@@ -64,6 +65,7 @@ void conversionHook() {
     assertThat(v2.getSpec().getAlteredValue()).isEqualTo("" + CR_SPEC_VALUE);
   }
 
+  @SuppressWarnings("SameParameterValue")
   private MultiVersionCustomResource createV1Resource(String name) {
     var res = new MultiVersionCustomResource();
     res.setMetadata(new ObjectMetaBuilder()