Skip to content

Commit e277997

Browse files
committed
refactor: fix suppressions
Signed-off-by: David Sondermann <[email protected]>
1 parent 7657c25 commit e277997

File tree

7 files changed

+8
-3
lines changed

7 files changed

+8
-3
lines changed

core/src/main/java/io/javaoperatorsdk/webhook/admission/mutation/AsyncDefaultAdmissionRequestMutator.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ public AsyncDefaultAdmissionRequestMutator(AsyncMutator<T> mutator, Cloner<T> cl
3232
}
3333

3434
@Override
35+
@SuppressWarnings("unchecked")
3536
public CompletionStage<AdmissionResponse> handle(AdmissionRequest admissionRequest) {
3637
Operation operation = Operation.valueOf(admissionRequest.getOperation());
3738
var originalResource = (T) getTargetResource(admissionRequest, operation);

core/src/main/java/io/javaoperatorsdk/webhook/admission/mutation/DefaultAdmissionRequestMutator.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ public DefaultAdmissionRequestMutator(Mutator<T> mutator, Cloner<T> cloner) {
2929
}
3030

3131
@Override
32+
@SuppressWarnings("unchecked")
3233
public AdmissionResponse handle(AdmissionRequest admissionRequest) {
3334
var operation = Operation.valueOf(admissionRequest.getOperation());
3435
var originalResource = (T) getTargetResource(admissionRequest, operation);

core/src/main/java/io/javaoperatorsdk/webhook/admission/validation/DefaultAdmissionRequestValidator.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ public DefaultAdmissionRequestValidator(Validator<T> validator) {
2020
}
2121

2222
@Override
23+
@SuppressWarnings("unchecked")
2324
public AdmissionResponse handle(AdmissionRequest admissionRequest) {
2425
var operation = Operation.valueOf(admissionRequest.getOperation());
2526
var originalResource = (T) getTargetResource(admissionRequest, operation);

core/src/main/java/io/javaoperatorsdk/webhook/clone/ObjectMapperCloner.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ public class ObjectMapperCloner<T> implements Cloner<T> {
88
private final ObjectMapper objectMapper = new ObjectMapper();
99

1010
@Override
11+
@SuppressWarnings("unchecked")
1112
public T clone(T object) {
1213
if (object == null) {
1314
return null;

core/src/main/java/io/javaoperatorsdk/webhook/conversion/AsyncConversionController.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ private CompletionStage<List<HasMetadata>> convertObjects(List<HasMetadata> obje
6464
});
6565
}
6666

67-
@SuppressWarnings({"unchecked", "rawtypes"})
67+
@SuppressWarnings("unchecked")
6868
private CompletableFuture<HasMetadata> mapObject(HasMetadata resource, String targetVersion) {
6969
var sourceVersion = Utils.versionOfApiVersion(resource.getApiVersion());
7070
var sourceToHubMapper = mappers.get(sourceVersion);

core/src/main/java/io/javaoperatorsdk/webhook/conversion/ConversionController.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,13 +44,12 @@ public ConversionReview handle(ConversionReview conversionReview) {
4444
}
4545
}
4646

47-
@SuppressWarnings("unchecked")
4847
private List<HasMetadata> convertObjects(List<HasMetadata> objects, String targetVersion) {
4948
return objects.stream().map(r -> mapObject(r, targetVersion))
5049
.collect(Collectors.toList());
5150
}
5251

53-
@SuppressWarnings({"unchecked", "rawtypes"})
52+
@SuppressWarnings("unchecked")
5453
private HasMetadata mapObject(HasMetadata resource, String targetVersion) {
5554
var sourceVersion = Utils.versionOfApiVersion(resource.getApiVersion());
5655
var sourceToHubMapper = mappers.get(sourceVersion);

samples/commons/src/test/java/io/javaoperatorsdk/webhook/sample/AbstractEndToEndTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
import static org.junit.jupiter.api.Assertions.assertThrows;
2323

2424
public class EndToEndTestBase {
25+
@SuppressWarnings("deprecation")
2526

2627
protected KubernetesClient client = new KubernetesClientBuilder().build();
2728

@@ -63,6 +64,7 @@ void conversionHook() {
6364
assertThat(v2.getSpec().getAlteredValue()).isEqualTo("" + CR_SPEC_VALUE);
6465
}
6566

67+
@SuppressWarnings("SameParameterValue")
6668
private MultiVersionCustomResource createV1Resource(String name) {
6769
var res = new MultiVersionCustomResource();
6870
res.setMetadata(new ObjectMetaBuilder()

0 commit comments

Comments
 (0)