🌱 Bump operator-controller; remove operator-framework/catalogd from deps #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azych
force-pushed
the
bump-operator-controller-1.2.0
branch
from
831873a to
1cc1f99
Compare
|
Looks good to me. Once we fix #224 (comment) we should be able to merge it. |
azych
force-pushed
the
bump-operator-controller-1.2.0
branch
from
1cc1f99 to
3ad6377
Compare
Signed-off-by: Artur Zych <[email protected]>
azych
force-pushed
the
bump-operator-controller-1.2.0
branch
from
3ad6377 to
e84aff3
Compare
| go 1.23.0 | ||
|
|
||
| toolchain go1.23.4 | ||
| go 1.23.4 |
There was a problem hiding this comment.
Since it is as we do in oper-controller: https://github.com/operator-framework/operator-controller/blob/main/go.mod#L3
I am fine with the change 👍
There was a problem hiding this comment.
yes, bump in go version comes (at least) from operator-controller 1.2.0 requirement
and since we use the same version in go and toolchain, go mod tidy removes the toolchain line as redundant because it means the same thing implicitly, see docs link here: #224 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context: #218 (comment)