🌱 change all 'operator(s)' references to 'extension(s)' in olmv1 commands #227
Conversation
azych
force-pushed
the
olmv1-operator-to-extension
branch
from
b1ee82b to
88bbd57
Compare
|
/hold let's get this in after #226 |
openshift-ci
bot
added
the
do-not-merge/hold
Signed-off-by: Artur Zych <[email protected]>
azych
force-pushed
the
olmv1-operator-to-extension
branch
from
88bbd57 to
66b6f5d
Compare
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
| Use: "install <extension>", | ||
| Short: "Install an extension", |
There was a problem hiding this comment.
| Use: "install <extension>", | |
| Short: "Install an extension", | |
| Use: "install <package name>", | |
| Short: "Install a cluster extension for a package", |
There was a problem hiding this comment.
I'm not sure about replacing extension with package name here. I think commonly and for user-facing purposes you'd say you want to install an (cluster)extension?
Package name seems like an implementation detail at this point and at least to me it could confuse people because we'd have crud operations mentioning (cluster)extension and then a package terminology at the root level.
There was a problem hiding this comment.
I agree with Ankita. Here is my suggestion
Use: "install <cluster extension name>",
Short: "Install a cluster extension",
There was a problem hiding this comment.
this is a simple rename PR and @LalatenduMohanty is working on install/uninstall commands that this comment touches. How about we have those discussions on that incoming PR where they belong?
There was a problem hiding this comment.
I'm fine with redoing the install help text in the v1 install/uninstall commands PR.
There was a problem hiding this comment.
Thats fine. I will fix it in my PR.
| Use: "install <extension>", | ||
| Short: "Install an extension", |
There was a problem hiding this comment.
I agree with Ankita. Here is my suggestion
Use: "install <cluster extension name>",
Short: "Install a cluster extension",
| Warning: this command permanently deletes objects from the cluster. If the | ||
| uninstalled Operator bundle contains CRDs, the CRDs will be deleted, which | ||
| uninstalled extension bundle contains CRDs, the CRDs will be deleted, which |
There was a problem hiding this comment.
we should not use extension and bundle at the same time. Use of bundle is associated with registry v1 content but not much with cluster extension.
There was a problem hiding this comment.
there is no functional change, it's just one-word rename, so I think bundle(s) are still being used to install operators/extensions.
That said, this is a simple rename PR and @LalatenduMohanty is working on install/uninstall commands that this comment touches. How about we have those discussions on that incoming PR where they belong?
3 participants
'Extension(s)' is the target nomenclature for what olmv1 is/will be able to handle and is used throughout our official documentation.
This PR changes all 'operator(s)' references in olmv1 commands and code to reflect that.