Skip to content

Reformatting and updating help documentation #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Dec 3, 2025
Merged

Reformatting and updating help documentation #241

merged 11 commits into from
Dec 3, 2025

Conversation

@ankitathomas
Copy link
Contributor

@ankitathomas ankitathomas commented Nov 25, 2025 •
edited
Loading

This PR tidies up the olmv1 CLI:

  • Moved most flag definitions out of each individual command's file into a common flags.go
  • Makes naming consistent across files
  • Ensures similar flags on different commands behave consistently (eg, --selector)
  • Adds a spinner to show some activity for long running processes
  • Cleaned up tests and removed deprecated dependencies

Fixes #237

@ankitathomas
clustercatalog content discovery for packages and bundle versions
d061592 
Signed-off-by: Ankita Thomas <[email protected]>
@ankitathomas
linter fixes
1c4b577 
Signed-off-by: Ankita Thomas <[email protected]>
@ankitathomas
reformat get commands
388c2ea 
Signed-off-by: Ankita Thomas <[email protected]>
@ankitathomas
reformat install commands
aaf1e45 
Signed-off-by: Ankita Thomas <[email protected]>
@ankitathomas
reformat update commands
7b8547f 
Signed-off-by: Ankita Thomas <[email protected]>
@ankitathomas
refactor delete commands
4a27912 
Signed-off-by: Ankita Thomas <[email protected]>
@ankitathomas
spinner
a6c02a8 
Signed-off-by: Ankita Thomas <[email protected]>
@ankitathomas
fix formatting and type conversion
dbbf5fc 
Signed-off-by: Ankita Thomas <[email protected]>
@ankitathomas
group common flags
1900b43 
Signed-off-by: Ankita Thomas <[email protected]>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 25, 2025
@openshift-ci openshift-ci bot requested review from benluddy and jmrodri November 25, 2025 07:30
@ankitathomas ankitathomas changed the title WIP: Reformatting and updating help documentation Reformatting and updating help documentation Dec 2, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 2, 2025
@ankitathomas ankitathomas force-pushed the reformatting branch 7 times, most recently from ef8e812 to e174558 Compare December 2, 2025 05:27
@ankitathomas
fixing tests
4fefd48 
Signed-off-by: Ankita Thomas <[email protected]>
rashmigottipati
rashmigottipati reviewed Dec 2, 2025
View reviewed changes
rashmigottipati
rashmigottipati reviewed Dec 2, 2025
View reviewed changes
@ankitathomas
fix log formatting
be9bdaf 
Signed-off-by: Ankita Thomas <[email protected]>
@ankitathomas ankitathomas added this pull request to the merge queue Dec 3, 2025
Merged via the queue into operator-framework:main with commit 882354c Dec 3, 2025
4 checks passed
@ankitathomas ankitathomas deleted the reformatting branch December 3, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benluddy benluddy Awaiting requested review from benluddy

@jmrodri jmrodri Awaiting requested review from jmrodri

@trgeiger trgeiger Awaiting requested review from trgeiger

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add clearer descriptions in --help output for olmv1 subcommands.

2 participants

@ankitathomas @rashmigottipati