WIP: ✨ Add support for registry+v1 bundles that include webhooks #4150
joelanfordAnnotations
10 errors and 2 warnings
|
lint:
internal/rukpak/convert/registryv1.go#L258
Consider pre-allocating `parameterizedFiles` (prealloc)
|
|
lint:
internal/rukpak/convert/registryv1.go#L362
Consider pre-allocating `chrtMaintainers` (prealloc)
|
|
lint:
internal/rukpak/convert/registryv1.go#L401
`newParameterizedFile` - `filename` always receives `""` (unparam)
|
|
lint:
internal/rukpak/convert/registryv1.go#L977
getSchema - result 1 (error) is always nil (unparam)
|
|
lint:
internal/rukpak/convert/registryv1_helpers_test.go#L98
assertFieldEqual - result 0 (bool) is never used (unparam)
|
|
lint:
internal/rukpak/convert/registryv1_test.go#L44
`TestRegistryV1ToHelmChart$1` - `chrt` is unused (unparam)
|
|
lint:
internal/rukpak/convert/registryv1_test.go#L434
unnecessary trailing newline (whitespace)
|
|
lint:
internal/rukpak/convert/certmanager.go#L30
ST1006: receiver name should not be an underscore, omit the name if it is unused (stylecheck)
|
|
lint:
internal/rukpak/convert/certmanager.go#L26
ST1006: receiver name should not be an underscore, omit the name if it is unused (stylecheck)
|
|
lint:
internal/rukpak/convert/registryv1_test.go#L269
require-error: for error assertions use require (testifylint)
|
|
verify
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
lint
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|