Skip to content
sanity

✨ Refactor rukpak convert (now with testing!) #5856

Sign in to view logs

✨ Refactor rukpak convert (now with testing!)

✨ Refactor rukpak convert (now with testing!) #5856

Triggered via pull request April 2, 2025 17:54
@perdasilvaperdasilva
synchronize #1893
perdasilva:add-render-framework
Status Failure
Total duration 3m 47s
Artifacts –

sanity.yaml

on: pull_request
verify
29s
verify
lint
3m 35s
lint
Fit to window
Zoom out
Zoom in

Annotations

11 errors
verify
Process completed with exit code 2.
lint: internal/operator-controller/rukpak/convert/render/generate.go#L4
File is not properly formatted (gci)
lint: internal/operator-controller/rukpak/convert/render/mutate.go#L4
File is not properly formatted (gci)
lint: internal/operator-controller/rukpak/convert/render/resources.go#L4
File is not properly formatted (gci)
lint: internal/operator-controller/rukpak/convert/render/generate.go#L81
Consider pre-allocating `objs` (prealloc)
lint: internal/operator-controller/rukpak/convert/render/generate_test.go#L330
expected-actual: need to reverse actual and expected values (testifylint)
lint: internal/operator-controller/rukpak/convert/render/resources_test.go#L38
expected-actual: need to reverse actual and expected values (testifylint)
lint: internal/operator-controller/rukpak/convert/render/resources_test.go#L39
expected-actual: need to reverse actual and expected values (testifylint)
lint: internal/operator-controller/rukpak/convert/render/generate.go#L156
unnecessary trailing newline (whitespace)
lint: internal/operator-controller/rukpak/convert/render/generate_test.go#L372
unnecessary trailing newline (whitespace)
lint
Process completed with exit code 2.