-
Notifications
You must be signed in to change notification settings - Fork 67
🌱 Add catalog exploration and extension rbac/installation scripts #1216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add catalog exploration and extension rbac/installation scripts #1216
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1216 +/- ##
=======================================
Coverage 76.47% 76.47%
=======================================
Files 40 40
Lines 2363 2363
=======================================
Hits 1807 1807
Misses 390 390
Partials 166 166
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
278b7ad
to
8d5aa3d
Compare
Is it worth adding some of these scripts and having to maintain them until we have proper tooling in place? Is there things that we've learned from writing these scripts that we can write up documentation on how to manually do all these things until the proper tooling is in place? |
8d5aa3d
to
b6e21ff
Compare
If you tell me we'll have the tools next week, then I agree. Otherwise, in my opinion, yes. I don't think I'd use a package manager that requires me to read/understand documentation and go through a whole bunch of manual steps including manually finding/pulling/unpacking the bundle, and inspecting its content. I think it makes sense to show the minimum amount of effort towards tooling to help facilitate user's lives. This script is in hack, the documentation calls it out as a not-guaranteed-to-work helper script to smooth things out until we have proper tools. How much maintenance do you foresee happening here? Will it be that much of a time sink? Is it really not worth it? |
b6e21ff
to
72eb4c9
Compare
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
c8a6b93
to
e8963a1
Compare
Signed-off-by: Per Goncalves da Silva <[email protected]>
e8963a1
to
849e477
Compare
@everettraven I think this is ready for merge ^^ |
Description
The lack of tooling can make finding and installing extensions hard. This PR adds some
hack/
scripts to help smooth over this rough edge until the proper tools are readyReviewer Checklist