Skip to content

Conversation

perdasilva
Copy link
Contributor

Description

The lack of tooling can make finding and installing extensions hard. This PR adds some hack/ scripts to help smooth over this rough edge until the proper tools are ready

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@perdasilva perdasilva requested a review from a team as a code owner September 5, 2024 07:44
Copy link

netlify bot commented Sep 5, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 849e477
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66e8122ab9280600085b2961
😎 Deploy Preview https://deploy-preview-1216--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.47%. Comparing base (3e2a884) to head (849e477).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1216   +/-   ##
=======================================
  Coverage   76.47%   76.47%           
=======================================
  Files          40       40           
  Lines        2363     2363           
=======================================
  Hits         1807     1807           
  Misses        390      390           
  Partials      166      166           
Flag Coverage Δ
e2e 57.85% <ø> (ø)
unit 53.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@perdasilva perdasilva force-pushed the perdasilva/tools/catalog branch 2 times, most recently from 278b7ad to 8d5aa3d Compare September 5, 2024 11:22
@everettraven
Copy link
Contributor

Is it worth adding some of these scripts and having to maintain them until we have proper tooling in place? Is there things that we've learned from writing these scripts that we can write up documentation on how to manually do all these things until the proper tooling is in place?

@perdasilva perdasilva force-pushed the perdasilva/tools/catalog branch from 8d5aa3d to b6e21ff Compare September 5, 2024 14:46
@perdasilva
Copy link
Contributor Author

perdasilva commented Sep 5, 2024

Is it worth adding some of these scripts and having to maintain them until we have proper tooling in place? Is there things that we've learned from writing these scripts that we can write up documentation on how to manually do all these things until the proper tooling is in place?

If you tell me we'll have the tools next week, then I agree. Otherwise, in my opinion, yes. I don't think I'd use a package manager that requires me to read/understand documentation and go through a whole bunch of manual steps including manually finding/pulling/unpacking the bundle, and inspecting its content. I think it makes sense to show the minimum amount of effort towards tooling to help facilitate user's lives. This script is in hack, the documentation calls it out as a not-guaranteed-to-work helper script to smooth things out until we have proper tools. How much maintenance do you foresee happening here? Will it be that much of a time sink? Is it really not worth it?

@perdasilva perdasilva force-pushed the perdasilva/tools/catalog branch from b6e21ff to 72eb4c9 Compare September 6, 2024 08:06
Per Goncalves da Silva added 7 commits September 13, 2024 09:26
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
@perdasilva perdasilva force-pushed the perdasilva/tools/catalog branch from c8a6b93 to e8963a1 Compare September 13, 2024 07:26
Signed-off-by: Per Goncalves da Silva <[email protected]>
@perdasilva perdasilva force-pushed the perdasilva/tools/catalog branch from e8963a1 to 849e477 Compare September 16, 2024 11:10
@perdasilva
Copy link
Contributor Author

@everettraven I think this is ready for merge ^^

@everettraven everettraven added this pull request to the merge queue Sep 16, 2024
Merged via the queue into operator-framework:main with commit e9584db Sep 16, 2024
17 checks passed
@skattoju skattoju mentioned this pull request Sep 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants