Skip to content

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Sep 11, 2024

The minimum should be 1.22.5 rather than 1.22.7

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

The minimum should be 1.22.5 rather than 1.22.7

Signed-off-by: Todd Short <[email protected]>
@tmshort tmshort requested a review from a team as a code owner September 11, 2024 14:40
Copy link

netlify bot commented Sep 11, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit ae4f2e6
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66e1abe5d6e93c000839898c
😎 Deploy Preview https://deploy-preview-1252--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@everettraven everettraven added this pull request to the merge queue Sep 11, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.49%. Comparing base (d09f325) to head (ae4f2e6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1252   +/-   ##
=======================================
  Coverage   76.49%   76.49%           
=======================================
  Files          40       40           
  Lines        2336     2336           
=======================================
  Hits         1787     1787           
  Misses        392      392           
  Partials      157      157           
Flag Coverage Δ
e2e 57.57% <ø> (ø)
unit 52.26% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into operator-framework:main with commit 9491b59 Sep 11, 2024
18 checks passed
@tmshort tmshort deleted the go1225 branch September 11, 2024 14:59
@skattoju skattoju mentioned this pull request Sep 25, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants